diff options
| author | yuuji.yaginuma <yuuji.yaginuma@gmail.com> | 2017-08-05 12:21:21 +0900 |
|---|---|---|
| committer | yuuji.yaginuma <yuuji.yaginuma@gmail.com> | 2017-08-05 12:22:39 +0900 |
| commit | 46db463d068d9b24c99f11a1c78dac1c1bfb45c2 (patch) | |
| tree | a85164df8a161609d2b00ee5268888ffdfaab05b /activestorage/test/service | |
| parent | 95ad242c8066e71c403d53ea634f347e357473b1 (diff) | |
| download | rails-46db463d068d9b24c99f11a1c78dac1c1bfb45c2.tar.gz rails-46db463d068d9b24c99f11a1c78dac1c1bfb45c2.tar.bz2 rails-46db463d068d9b24c99f11a1c78dac1c1bfb45c2.zip | |
Fix ruby warnings
This fixes following warnings:
```
test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator
lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized
lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized
```
Diffstat (limited to 'activestorage/test/service')
| -rw-r--r-- | activestorage/test/service/disk_service_test.rb | 4 | ||||
| -rw-r--r-- | activestorage/test/service/s3_service_test.rb | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/activestorage/test/service/disk_service_test.rb b/activestorage/test/service/disk_service_test.rb index a625521601..2fdb113616 100644 --- a/activestorage/test/service/disk_service_test.rb +++ b/activestorage/test/service/disk_service_test.rb @@ -6,7 +6,7 @@ class ActiveStorage::Service::DiskServiceTest < ActiveSupport::TestCase include ActiveStorage::Service::SharedServiceTests test "url generation" do - assert_match /rails\/active_storage\/disk\/.*\/avatar\.png\?.+disposition=inline/, - @service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png", content_type: "image/png") + assert_match(/rails\/active_storage\/disk\/.*\/avatar\.png\?.+disposition=inline/, + @service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png", content_type: "image/png")) end end diff --git a/activestorage/test/service/s3_service_test.rb b/activestorage/test/service/s3_service_test.rb index 6d613fd4fc..57e13e6538 100644 --- a/activestorage/test/service/s3_service_test.rb +++ b/activestorage/test/service/s3_service_test.rb @@ -33,7 +33,7 @@ if SERVICE_CONFIGURATIONS[:s3] && SERVICE_CONFIGURATIONS[:s3][:access_key_id].pr url = @service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png", content_type: "image/png") - assert_match /s3\.(\S+)?amazonaws.com.*response-content-disposition=inline.*avatar\.png.*response-content-type=image%2Fpng/, url + assert_match(/s3\.(\S+)?amazonaws.com.*response-content-disposition=inline.*avatar\.png.*response-content-type=image%2Fpng/, url) assert_match SERVICE_CONFIGURATIONS[:s3][:bucket], url end |