Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin block

Currently we sometimes find a redundant begin block in code review
(e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205).

I'd like to enable `Style/RedundantBegin` cop to avoid that, since
rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5
(https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with
that situation than before.

1 files changed, 11 insertions, 13 deletions

diff --git a/activestorage/test/service/azure_storage_service_test.rb b/activestorage/test/service/azure_storage_service_test.rb
index 09c2e7f99c..2b07902d07 100644
--- a/activestorage/test/service/azure_storage_service_test.rb
+++ b/activestorage/test/service/azure_storage_service_test.rb
@@ -18,20 +18,18 @@ if SERVICE_CONFIGURATIONS[:azure]
     end
 
     test "uploading a tempfile" do
-      begin
-        key  = SecureRandom.base58(24)
-        data = "Something else entirely!"
-
-        Tempfile.open do |file|
-          file.write(data)
-          file.rewind
-          @service.upload(key, file)
-        end
-
-        assert_equal data, @service.download(key)
-      ensure
-        @service.delete(key)
+      key  = SecureRandom.base58(24)
+      data = "Something else entirely!"
+
+      Tempfile.open do |file|
+        file.write(data)
+        file.rewind
+        @service.upload(key, file)
       end
+
+      assert_equal data, @service.download(key)
+    ensure
+      @service.delete(key)
     end
   end
 else