diff options
| author | Bibek Shrestha <bibekshrestha@gmail.com> | 2018-07-04 17:04:26 -0400 |
|---|---|---|
| committer | Bibek Shrestha <bibekshrestha@gmail.com> | 2018-07-04 17:04:26 -0400 |
| commit | 637a8cde59ebb9ba97605e54ec875e3fd9e6474d (patch) | |
| tree | 17ada0e5050380fb93f1f35047c60a8463bcd177 /activestorage/lib/active_storage/service | |
| parent | 80a9510b753132a46a69571a1e8db7fcf3368f65 (diff) | |
| download | rails-637a8cde59ebb9ba97605e54ec875e3fd9e6474d.tar.gz rails-637a8cde59ebb9ba97605e54ec875e3fd9e6474d.tar.bz2 rails-637a8cde59ebb9ba97605e54ec875e3fd9e6474d.zip | |
Remove vestigial require on ActiveStorage GCSService
The file `filename.rb` as mentioned in `require "active_storage/filename"`
belongs to the `app` folder while GCSService belongs to the lib folder.
Looking at the git blame, it was added in commit https://github.com/rails/rails/commit/ccac681122db9747fec9512076772bca345e24b9#diff-bda6a610ef1575b2c8458c96b7f12578
where ActiveStorage::Filename was actually used. But it is no longer
required on master and therefore can be removed.
This allows anyone to use GCSService directly without enabling
ActiveStorage engine.
Diffstat (limited to 'activestorage/lib/active_storage/service')
| -rw-r--r-- | activestorage/lib/active_storage/service/gcs_service.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/activestorage/lib/active_storage/service/gcs_service.rb b/activestorage/lib/active_storage/service/gcs_service.rb index 38acef81f4..fdde01d4a3 100644 --- a/activestorage/lib/active_storage/service/gcs_service.rb +++ b/activestorage/lib/active_storage/service/gcs_service.rb @@ -6,7 +6,6 @@ require "google/cloud/storage" require "net/http" require "active_support/core_ext/object/to_query" -require "active_storage/filename" module ActiveStorage # Wraps the Google Cloud Storage as an Active Storage service. See ActiveStorage::Service for the generic API |