diff options
author | Yasuo Honda <yasuo.honda@gmail.com> | 2019-05-02 21:55:36 +0000 |
---|---|---|
committer | Yasuo Honda <yasuo.honda@gmail.com> | 2019-05-03 00:21:00 +0000 |
commit | 36483cdb486fb72ef08ada2a60a0085f2bf66f2f (patch) | |
tree | ccbc187290a55f0f50b63c9ffbebd8128787e29d /activestorage/app/models/active_storage | |
parent | 1ce5153a099e82f761315154dfe5e01253dafd81 (diff) | |
download | rails-36483cdb486fb72ef08ada2a60a0085f2bf66f2f.tar.gz rails-36483cdb486fb72ef08ada2a60a0085f2bf66f2f.tar.bz2 rails-36483cdb486fb72ef08ada2a60a0085f2bf66f2f.zip |
Remove redundant `test_too_many_binds`
with `ActiveRecord::BindParameterTest#test_too_many_binds`
sqlite adapter has its own `bind_params_length`, `ActiveRecord::BindParameterTest#test_too_many_binds` respects it.
* Modified `ActiveRecord::BindParameterTest#test_too_many_binds` to show `bind_params_length` value
```
$ git diff
diff --git a/activerecord/test/cases/bind_parameter_test.rb b/activerecord/test/cases/bind_parameter_test.rb
index 85685d1d00..83cd07f1d7 100644
--- a/activerecord/test/cases/bind_parameter_test.rb
+++ b/activerecord/test/cases/bind_parameter_test.rb
@@ -108,6 +108,7 @@ def test_statement_cache_with_sql_string_literal
def test_too_many_binds
bind_params_length = @connection.send(:bind_params_length)
+ p bind_params_length
topics = Topic.where(id: (1 .. bind_params_length).to_a << 2**63)
assert_equal Topic.count, topics.count
$
```
* Executed modified `ActiveRecord::BindParameterTest#test_too_many_binds`
```
$ bin/test test/cases/bind_parameter_test.rb -n test_too_many_binds
Using sqlite3
Run options: -n test_too_many_binds --seed 47321
999
.
Finished in 0.075249s, 13.2892 runs/s, 26.5784 assertions/s.
1 runs, 2 assertions, 0 failures, 0 errors, 0 skips
$
```
Diffstat (limited to 'activestorage/app/models/active_storage')
0 files changed, 0 insertions, 0 deletions