diff options
| author | Cameron Bothner <cameronbothner@gmail.com> | 2018-08-20 17:35:36 -0400 |
|---|---|---|
| committer | Cameron Bothner <cameronbothner@gmail.com> | 2018-08-23 17:54:35 -0400 |
| commit | 6acf2fa363cee293286578b83646af4015a140df (patch) | |
| tree | f821c5251b80d84a5024a8b49bbe1c69e1338a31 /activestorage/CHANGELOG.md | |
| parent | de6a200f82a3de399fa685d583503bc88dbc5e9f (diff) | |
| download | rails-6acf2fa363cee293286578b83646af4015a140df.tar.gz rails-6acf2fa363cee293286578b83646af4015a140df.tar.bz2 rails-6acf2fa363cee293286578b83646af4015a140df.zip | |
Handle only specifically relevant Azure HTTPErrors
The Azure gem uses `Azure::Core::Http::HTTPError` for everything:
checksum mismatch, missing object, network unavailable, and many more.
(https://www.rubydoc.info/github/yaxia/azure-storage-ruby/Azure/Core/Http/HTTPError).
Rescuing that class obscures all sorts of configuration errors. We
should check the type of error in those rescue blocks, and reraise when
needed.
Diffstat (limited to 'activestorage/CHANGELOG.md')
| -rw-r--r-- | activestorage/CHANGELOG.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/activestorage/CHANGELOG.md b/activestorage/CHANGELOG.md index b592f79ca6..92e300a440 100644 --- a/activestorage/CHANGELOG.md +++ b/activestorage/CHANGELOG.md @@ -1,3 +1,10 @@ +* `ActiveStorage::Service::AzureStorageService` only handles specifically + relevant types of `Azure::Core::Http::HTTPError`. It previously obscured + other types of `HTTPError`, which is the azure-storage gem’s catch-all + exception class. + + *Cameron Bothner* + * `ActiveStorage::DiskController#show` generates a 404 Not Found response when the requested file is missing from the disk service. It previously raised `Errno::ENOENT`. |