edit pass over all warnings

This patch uniformizes warning messages. I used the most common style
already present in the code base:

* Capitalize the first word.

* End the message with a full stop.

* "Rails 5" instead of "Rails 5.0".

* Backticks for method names and inline code.

Also, converted a few long strings into the new heredoc convention.

7 files changed, 19 insertions, 16 deletions

diff --git a/activerecord/lib/active_record/associations/has_many_through_association.rb b/activerecord/lib/active_record/associations/has_many_through_association.rb
index 1b84fdf5f2..04a69ba446 100644
--- a/activerecord/lib/active_record/associations/has_many_through_association.rb
+++ b/activerecord/lib/active_record/associations/has_many_through_association.rb
@@ -67,9 +67,9 @@ module ActiveRecord
         if has_cached_counter? && !through_reflection_updates_counter_cache?
           ActiveSupport::Deprecation.warn(<<-MSG.squish)
             Automatic updating of counter caches on through associations has been
-            deprecated, and will be removed in Rails 5.0. Instead, please set the
-            appropriate counter_cache options on the has_many and belongs_to for
-            your associations to #{through_reflection.name}.
+            deprecated, and will be removed in Rails 5. Instead, please set the
+            appropriate `counter_cache` options on the `has_many` and `belongs_to`
+            for your associations to #{through_reflection.name}.
           MSG
 
           update_counter_in_database(1)
diff --git a/activerecord/lib/active_record/attribute_methods.rb b/activerecord/lib/active_record/attribute_methods.rb
index 6ee4efe7f6..34ec397aee 100644
--- a/activerecord/lib/active_record/attribute_methods.rb
+++ b/activerecord/lib/active_record/attribute_methods.rb
@@ -207,8 +207,8 @@ module ActiveRecord
         column = columns_hash[name.to_s]
         if column.nil?
           ActiveSupport::Deprecation.warn(<<-MSG.squish)
-            `column_for_attribute` will return a null object for non-existent
-            columns in Rails 5.0. Use `has_attribute?` if you need to check for
+            `#column_for_attribute` will return a null object for non-existent
+            columns in Rails 5. Use `#has_attribute?` if you need to check for
             an attribute's existence.
           MSG
         end
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb b/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb
index e197f7f2f9..46812b75bb 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb
@@ -520,7 +520,7 @@ module ActiveRecord
 
       def connection_pools
         ActiveSupport::Deprecation.warn(<<-MSG.squish)
-          In the next release, this will return the same as #connection_pool_list.
+          In the next release, this will return the same as `#connection_pool_list`.
           (An array of pools, rather than a hash mapping specs to pools.)
         MSG
 
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
index 1aed8b0457..f8b6daea5a 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
@@ -61,10 +61,9 @@ module ActiveRecord
         return if options.key?(:null)
 
         ActiveSupport::Deprecation.warn(<<-MSG.squish)
-          `timestamp` was called without specifying an option for `null`. In Rails
-          5.0, this behavior will change to `null: false`. You should manually
-          specify `null: true` to prevent the behavior of your existing migrations
-          from changing.
+          `#timestamp` was called without specifying an option for `null`. In Rails 5,
+          this behavior will change to `null: false`. You should manually specify
+         `null: true` to prevent the behavior of your existing migrations from changing.
         MSG
       end
     end
diff --git a/activerecord/lib/active_record/connection_adapters/connection_specification.rb b/activerecord/lib/active_record/connection_adapters/connection_specification.rb
index af405fc690..609ec7dabd 100644
--- a/activerecord/lib/active_record/connection_adapters/connection_specification.rb
+++ b/activerecord/lib/active_record/connection_adapters/connection_specification.rb
@@ -225,7 +225,7 @@ module ActiveRecord
             ActiveSupport::Deprecation.warn(<<-MSG.squish)
               Passing a string to ActiveRecord::Base.establish_connection for a
               configuration lookup is deprecated, please pass a symbol
-              (#{spec.to_sym.inspect}) instead
+              (#{spec.to_sym.inspect}) instead.
             MSG
 
             resolve_symbol_connection(spec)
diff --git a/activerecord/lib/active_record/inheritance.rb b/activerecord/lib/active_record/inheritance.rb
index 251d682a02..f58145ab05 100644
--- a/activerecord/lib/active_record/inheritance.rb
+++ b/activerecord/lib/active_record/inheritance.rb
@@ -80,12 +80,12 @@ module ActiveRecord
       end
 
       def symbolized_base_class
-        ActiveSupport::Deprecation.warn("ActiveRecord::Base.symbolized_base_class is deprecated and will be removed without replacement.")
+        ActiveSupport::Deprecation.warn('`ActiveRecord::Base.symbolized_base_class` is deprecated and will be removed without replacement.')
         @symbolized_base_class ||= base_class.to_s.to_sym
       end
 
       def symbolized_sti_name
-        ActiveSupport::Deprecation.warn("ActiveRecord::Base.symbolized_sti_name is deprecated and will be removed without replacement.")
+        ActiveSupport::Deprecation.warn('`ActiveRecord::Base.symbolized_sti_name` is deprecated and will be removed without replacement.')
         @symbolized_sti_name ||= sti_name.present? ? sti_name.to_sym : symbolized_base_class
       end
 
diff --git a/activerecord/lib/active_record/type/boolean.rb b/activerecord/lib/active_record/type/boolean.rb
index 612478e67d..978d16d524 100644
--- a/activerecord/lib/active_record/type/boolean.rb
+++ b/activerecord/lib/active_record/type/boolean.rb
@@ -14,9 +14,13 @@ module ActiveRecord
           true
         else
           if !ConnectionAdapters::Column::FALSE_VALUES.include?(value)
-            ActiveSupport::Deprecation.warn(<<-EOM)
-              You attempted to assign a value which is not explicitly true or false to a boolean column. Currently this value casts to false. This will change to match Ruby's semantics, and will cast to true in Rails 5.0. If you would like to maintain the current behavior, you should explicitly handle the values you would like cast to false.
-            EOM
+            ActiveSupport::Deprecation.warn(<<-MSG.squish)
+              You attempted to assign a value which is not explicitly `true` or `false`
+              to a boolean column. Currently this value casts to `false`. This will
+              change to match Ruby's semantics, and will cast to `true` in Rails 5.
+              If you would like to maintain the current behavior, you should
+              explicitly handle the values you would like cast to `false`.
+            MSG
           end
           false
         end