aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorYasuo Honda <yasuo.honda@gmail.com>2018-11-25 13:41:01 +0000
committerYasuo Honda <yasuo.honda@gmail.com>2018-11-25 23:08:25 +0000
commitd56a6e19c471662d9a32c6b866b10d23ec7bb05a (patch)
tree467e02267258bf33db4d65d2b5f0154ad4c60f6f /activerecord
parentd6fcc419fe4f99d3f9414d39d081bd6355842018 (diff)
downloadrails-d56a6e19c471662d9a32c6b866b10d23ec7bb05a.tar.gz
rails-d56a6e19c471662d9a32c6b866b10d23ec7bb05a.tar.bz2
rails-d56a6e19c471662d9a32c6b866b10d23ec7bb05a.zip
SQLite 3.7.16+ returns the order of the primary key columns
https://www.sqlite.org/releaselog/3_7_16.html > 9 Enhance the PRAGMA table_info command so that the "pk" column is an increasing integer to show the order of columns in the primary key. Rails 6 supports SQLite 3.8 then we can remove this skip condition.
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/test/cases/primary_keys_test.rb2
1 files changed, 0 insertions, 2 deletions
diff --git a/activerecord/test/cases/primary_keys_test.rb b/activerecord/test/cases/primary_keys_test.rb
index 4ed7469039..4759d3b6b2 100644
--- a/activerecord/test/cases/primary_keys_test.rb
+++ b/activerecord/test/cases/primary_keys_test.rb
@@ -354,7 +354,6 @@ class CompositePrimaryKeyTest < ActiveRecord::TestCase
end
def test_composite_primary_key_out_of_order
- skip if current_adapter?(:SQLite3Adapter)
assert_equal ["code", "region"], @connection.primary_keys("barcodes_reverse")
end
@@ -376,7 +375,6 @@ class CompositePrimaryKeyTest < ActiveRecord::TestCase
end
def test_dumping_composite_primary_key_out_of_order
- skip if current_adapter?(:SQLite3Adapter)
schema = dump_table_schema "barcodes_reverse"
assert_match %r{create_table "barcodes_reverse", primary_key: \["code", "region"\]}, schema
end