diff options
| author | Yves Senn <yves.senn@gmail.com> | 2016-02-16 09:43:39 +0100 |
|---|---|---|
| committer | Yves Senn <yves.senn@gmail.com> | 2016-02-16 09:44:08 +0100 |
| commit | cf0b903f43369cafe3ef5f3a789c4a62f80d379d (patch) | |
| tree | e03e191a2a50618c27b44c751b15bcd40784683a /activerecord | |
| parent | 6795f33b339356df6a72d445fc2630375abc4852 (diff) | |
| parent | 8d3912ac24c12eec9e37bd457c17941b6c2a64a3 (diff) | |
| download | rails-cf0b903f43369cafe3ef5f3a789c4a62f80d379d.tar.gz rails-cf0b903f43369cafe3ef5f3a789c4a62f80d379d.tar.bz2 rails-cf0b903f43369cafe3ef5f3a789c4a62f80d379d.zip | |
Merge pull request #23706 from vipulnsward/add-changelog-for-regression
Add missing CHANGELOG for regression fix in #18155 which fixes #13387
Diffstat (limited to 'activerecord')
| -rw-r--r-- | activerecord/CHANGELOG.md | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index f13a80195a..bc5eb483b8 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,5 +1,12 @@ -* Rework `ActiveRecord::Relation#last` - +* Fix a regression on has many association, where calling a child from parent in child's callback + results in same child records getting added repeatedly to target. + + Fixes #13387. + + *Bogdan Gusiev*, *Jon Hinson* + +* Rework `ActiveRecord::Relation#last` + 1. Never perform additional SQL on loaded relation 2. Use SQL reverse order instead of loading relation if relation doesn't have limit 3. Deprecated relation loading when SQL order can not be automatically reversed |