Refactor test to not care about the specific result of valid?

Only care about its truthiness rather than asserting specific true/false
values. If we need to check for the return value in particular, there will
be a test for that.

1 files changed, 4 insertions, 3 deletions

diff --git a/activerecord/test/cases/associations/has_many_associations_test.rb b/activerecord/test/cases/associations/has_many_associations_test.rb
index d748e80695..70afbe1332 100644
--- a/activerecord/test/cases/associations/has_many_associations_test.rb
+++ b/activerecord/test/cases/associations/has_many_associations_test.rb
@@ -1886,11 +1886,12 @@ class HasManyAssociationsTest < ActiveRecord::TestCase
     end
   end
 
-  test 'has_many_association passes context validation to validate children' do
+  test 'passes custom context validation to validate children' do
     pirate = FamousPirate.new
     pirate.famous_ships << ship = FamousShip.new
-    assert_equal true, pirate.valid?
-    assert_equal false, pirate.valid?(:conference)
+
+    assert pirate.valid?
+    assert_not pirate.valid?(:conference)
     assert_equal "can't be blank", ship.errors[:name].first
   end
 end