aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorRafael França <rafaelmfranca@gmail.com>2016-02-17 04:02:27 -0200
committerRafael França <rafaelmfranca@gmail.com>2016-02-17 04:02:27 -0200
commitbb4a85da1011fecf4da6fe5b7ed73d3ba9e2e7f3 (patch)
treec9984cd4a2216cb928784ea9e54127e061c316d0 /activerecord
parentc60fb74dc6ea373bfe3d04731a2d2b6ba641f850 (diff)
parentb13a00ede657aea3673cecc2e40f4b3d26d51e79 (diff)
downloadrails-bb4a85da1011fecf4da6fe5b7ed73d3ba9e2e7f3.tar.gz
rails-bb4a85da1011fecf4da6fe5b7ed73d3ba9e2e7f3.tar.bz2
rails-bb4a85da1011fecf4da6fe5b7ed73d3ba9e2e7f3.zip
Merge pull request #23726 from akshaymohite/fix-test-names-in-batches-test
Fix semantics of test names for finish option in batches_test
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/test/cases/batches_test.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/test/cases/batches_test.rb b/activerecord/test/cases/batches_test.rb
index 3602ee7ba2..84aac3e721 100644
--- a/activerecord/test/cases/batches_test.rb
+++ b/activerecord/test/cases/batches_test.rb
@@ -108,7 +108,7 @@ class EachTest < ActiveRecord::TestCase
end
end
- def test_find_in_batches_should_finish_the_end_option
+ def test_find_in_batches_should_end_at_the_finish_option
assert_queries(6) do
Post.find_in_batches(batch_size: 1, finish: 5) do |batch|
assert_kind_of Array, batch
@@ -316,7 +316,7 @@ class EachTest < ActiveRecord::TestCase
end
end
- def test_in_batches_should_finish_the_end_option
+ def test_in_batches_should_end_at_the_finish_option
post = Post.order('id DESC').where('id <= ?', 5).first
assert_queries(7) do
relation = Post.in_batches(of: 1, finish: 5, load: true).reverse_each.first