+* Added dynamic scopes ala dynamic finders #1648 [Yaroslav Markin]

+

+ autoload :DynamicScopeMatch, 'active_record/dynamic_scope_match'

+ id_to_record_map, ids = construct_id_map(records, reflection.options[:primary_key])

+ id_to_record_map, ids = construct_id_map(records, primary_key_name || reflection.options[:primary_key])

+ super("Could not find the source association(s) #{source_reflection_names.collect(&:inspect).to_sentence :two_words_connector => ' or ', :last_word_connector => ', or '} in model #{through_reflection.klass}. Try 'has_many #{reflection.name.inspect}, :through => #{through_reflection.name.inspect}, :source => <name>'. Is it one of #{source_associations.to_sentence :two_words_connector => ' or ', :last_word_connector => ', or '}?")

+ reflection.options[:primary_key] || parent.primary_key

+ unless @owner.new_record?

+ primary_key = @reflection.options[:primary_key] || :id

+ record[@reflection.primary_key_name] = @owner.send(primary_key)

+ end

+ elsif match = DynamicScopeMatch.match(method_id)

+ return true if all_attributes_exists?(match.attribute_names)

+

+ # Also enables dynamic scopes like scoped_by_user_name(user_name) and scoped_by_user_name_and_password(user_name, password) that

+ # are turned into scoped(:conditions => ["user_name = ?", user_name]) and scoped(:conditions => ["user_name = ? AND password = ?", user_name, password])

+ # respectively.

+ # Each dynamic finder, scope or initializer/creator is also defined in the class after it is first invoked, so that future

+ # attempts to use it do not run through method_missing.

+ elsif match = DynamicScopeMatch.match(method_id)

+ attribute_names = match.attribute_names

+ super unless all_attributes_exists?(attribute_names)

+ if match.scope?

+ self.class_eval %{

+ def self.#{method_id}(*args) # def self.scoped_by_user_name_and_password(*args)

+ options = args.extract_options! # options = args.extract_options!

+ attributes = construct_attributes_from_arguments( # attributes = construct_attributes_from_arguments(

+ [:#{attribute_names.join(',:')}], args # [:user_name, :password], args

+ ) # )

+ #

+ scoped(:conditions => attributes) # scoped(:conditions => attributes)

+ end # end

+ }, __FILE__, __LINE__

+ send(method_id, *arguments)

+ end

+ if @connection.respond_to?(:transaction_active?) && @connection.transaction_active?

+ raise StatementInvalid, 'Cannot add columns to a SQLite database while inside a transaction'

+ end

+

+module ActiveRecord

+ class DynamicScopeMatch

+ def self.match(method)

+ ds_match = self.new(method)

+ ds_match.scope ? ds_match : nil

+ end

+

+ def initialize(method)

+ @scope = true

+ case method.to_s

+ when /^scoped_by_([_a-zA-Z]\w*)$/

+ names = $1

+ else

+ @scope = nil

+ end

+ @attribute_names = names && names.split('_and_')

+ end

+

+ attr_reader :scope, :attribute_names

+

+ def scope?

+ !@scope.nil?

+ end

+ end

+end

+

+ def test_preload_has_many_using_primary_key

+ expected = Firm.find(:first).clients_using_primary_key.to_a

+ firm = Firm.find :first, :include => :clients_using_primary_key

+ assert_no_queries do

+ assert_equal expected, firm.clients_using_primary_key

+ end

+ end

+

+ def test_include_has_many_using_primary_key

+ expected = Firm.find(1).clients_using_primary_key.sort_by &:name

+ firm = Firm.find 1, :include => :clients_using_primary_key, :order => 'clients_using_primary_keys_companies.name'

+ assert_no_queries do

+ assert_equal expected, firm.clients_using_primary_key

+ end

+ end

+

+ def test_preload_has_one_using_primary_key

+ expected = Firm.find(:first).account_using_primary_key

+ firm = Firm.find :first, :include => :account_using_primary_key

+ assert_no_queries do

+ assert_equal expected, firm.account_using_primary_key

+ end

+ end

+

+ def test_include_has_one_using_primary_key

+ expected = Firm.find(1).account_using_primary_key

+ firm = Firm.find(:all, :include => :account_using_primary_key, :order => 'accounts.id').detect {|f| f.id == 1}

+ assert_no_queries do

+ assert_equal expected, firm.account_using_primary_key

+ end

+ end

+

+

+ def test_creating_using_primary_key

+ firm = Firm.find(:first)

+ client = firm.clients_using_primary_key.create!(:name => 'test')

+ assert_equal firm.name, client.firm_name

+ end

+ assert_equal Developer.find_all_by_name('Jamis').to_set, Developer.find_all_by_id(Developer.jamises).to_set

+

+class DynamicScopeMatchTest < ActiveRecord::TestCase

+ def test_scoped_by_no_match

+ assert_nil ActiveRecord::DynamicScopeMatch.match("not_scoped_at_all")

+ end

+

+ def test_scoped_by

+ match = ActiveRecord::DynamicScopeMatch.match("scoped_by_age_and_sex_and_location")

+ assert_not_nil match

+ assert match.scope?

+ assert_equal %w(age sex location), match.attribute_names

+ end

+end

+

+class DynamicScopeTest < ActiveRecord::TestCase

+ def test_dynamic_scope

+ assert_equal Post.scoped_by_author_id(1).find(1), Post.find(1)

+ assert_equal Post.scoped_by_author_id_and_title(1, "Welcome to the weblog").first, Post.find(:first, :conditions => { :author_id => 1, :title => "Welcome to the weblog"})

+ end

+end