Use explicit method definition instead of metaprogramming.

1 files changed, 16 insertions, 11 deletions

diff --git a/activerecord/lib/active_record/relation.rb b/activerecord/lib/active_record/relation.rb
index 0d43c53d10..9c7ba881fc 100644
--- a/activerecord/lib/active_record/relation.rb
+++ b/activerecord/lib/active_record/relation.rb
@@ -1,7 +1,6 @@
 module ActiveRecord
   class Relation
-    delegate :delete, :to_sql, :to => :relation
-    CLAUSES_METHODS = ["group", "order", "on"].freeze
+    delegate :to_sql, :to => :relation
     attr_reader :relation, :klass
 
     def initialize(klass, table = nil)
@@ -22,20 +21,26 @@ module ActiveRecord
       to_a.first
     end
 
-    for clause in CLAUSES_METHODS
-      class_eval %{
-        def #{clause}!(_#{clause})
-          @relation = @relation.#{clause}(_#{clause}) if _#{clause}
-          self
-        end
-      }
-    end
-
     def select!(selection)
       @relation = @relation.project(selection) if selection
       self
     end
 
+    def on!(on)
+      @relation = @relation.on(on) if on
+      self
+    end
+
+    def order!(order)
+      @relation = @relation.order(order) if order
+      self
+    end
+
+    def group!(group)
+      @relation = @relation.group(group) if group
+      self
+    end
+
     def limit!(limit)
       @relation = @relation.take(limit) if limit
       self