diff options
author | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2013-07-01 12:44:42 -0700 |
---|---|---|
committer | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2013-07-01 12:44:42 -0700 |
commit | a91b48e27931a7625b17976249ae82e134416a53 (patch) | |
tree | 6eb5521fdb53dccc1c67f484319cafc212350fa1 /activerecord | |
parent | 42cf96fe9c2af46fdc772135bf282458ff241111 (diff) | |
parent | 1f45d3c94d83def09c8f02bafea39de142694a57 (diff) | |
download | rails-a91b48e27931a7625b17976249ae82e134416a53.tar.gz rails-a91b48e27931a7625b17976249ae82e134416a53.tar.bz2 rails-a91b48e27931a7625b17976249ae82e134416a53.zip |
Merge pull request #11221 from neerajdotname/partial_updates_family
Removed deprecated methods partial_updates and family
Diffstat (limited to 'activerecord')
-rw-r--r-- | activerecord/CHANGELOG.md | 5 | ||||
-rw-r--r-- | activerecord/lib/active_record/attribute_methods/dirty.rb | 11 | ||||
-rw-r--r-- | activerecord/test/cases/dirty_test.rb | 14 |
3 files changed, 5 insertions, 25 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index d6d79dffac..2b0195c5b6 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,8 @@ +* Removed deprecated methods `partial_updates`, `partial_updates?` and + `partial_updates=`. + + *Neeraj Singh* + * Removed deprecated method `scoped` *Neeraj Singh* diff --git a/activerecord/lib/active_record/attribute_methods/dirty.rb b/activerecord/lib/active_record/attribute_methods/dirty.rb index 6315dd9549..dc2399643c 100644 --- a/activerecord/lib/active_record/attribute_methods/dirty.rb +++ b/activerecord/lib/active_record/attribute_methods/dirty.rb @@ -14,17 +14,6 @@ module ActiveRecord class_attribute :partial_writes, instance_writer: false self.partial_writes = true - - def self.partial_updates=(v); self.partial_writes = v; end - def self.partial_updates?; partial_writes?; end - def self.partial_updates; partial_writes; end - - ActiveSupport::Deprecation.deprecate_methods( - singleton_class, - :partial_updates= => :partial_writes=, - :partial_updates? => :partial_writes?, - :partial_updates => :partial_writes - ) end # Attempts to +save+ the record and clears changed attributes if successful. diff --git a/activerecord/test/cases/dirty_test.rb b/activerecord/test/cases/dirty_test.rb index 36b87033ae..b277ef0317 100644 --- a/activerecord/test/cases/dirty_test.rb +++ b/activerecord/test/cases/dirty_test.rb @@ -608,20 +608,6 @@ class DirtyTest < ActiveRecord::TestCase end end - test "partial_updates config attribute is deprecated" do - klass = Class.new(ActiveRecord::Base) - - assert klass.partial_writes? - assert_deprecated { assert klass.partial_updates? } - assert_deprecated { assert klass.partial_updates } - - assert_deprecated { klass.partial_updates = false } - - assert !klass.partial_writes? - assert_deprecated { assert !klass.partial_updates? } - assert_deprecated { assert !klass.partial_updates } - end - private def with_partial_writes(klass, on = true) old = klass.partial_writes? |