aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorArun Agrawal <arunagw@gmail.com>2013-07-03 20:52:56 +0200
committerArun Agrawal <arunagw@gmail.com>2013-07-03 23:23:11 +0200
commit9105c59af05d3219e2811cab0642badbb4af5398 (patch)
tree192f007ce3e096ad42dfaceeed7d1c79cecd61f8 /activerecord
parentb23501112e40f8e8fff3676147c8a4aa8d8a4aa3 (diff)
downloadrails-9105c59af05d3219e2811cab0642badbb4af5398.tar.gz
rails-9105c59af05d3219e2811cab0642badbb4af5398.tar.bz2
rails-9105c59af05d3219e2811cab0642badbb4af5398.zip
Remove deprecated `transaction_joinable=`
in favor of `begin_transaction` with `:joinable` option.
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/CHANGELOG.md5
-rw-r--r--activerecord/lib/active_record/connection_adapters/abstract_adapter.rb6
-rw-r--r--activerecord/test/cases/transactions_test.rb9
3 files changed, 5 insertions, 15 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index e13aa74de8..d64d23613f 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,8 @@
+* Remove deprecated `transaction_joinable=` in favor of `begin_transaction`
+ with `:joinable` option.
+
+ *Arun Agrawal*
+
* Remove deprecated `decrement_open_transactions`.
*Arun Agrawal*
diff --git a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
index 5887e6e0cd..cfff7202a3 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
@@ -387,12 +387,6 @@ module ActiveRecord
@transaction.number
end
- def transaction_joinable=(joinable)
- message = "#transaction_joinable= is deprecated. Please pass the :joinable option to #begin_transaction instead."
- ActiveSupport::Deprecation.warn message
- @transaction.joinable = joinable
- end
-
def create_savepoint
end
diff --git a/activerecord/test/cases/transactions_test.rb b/activerecord/test/cases/transactions_test.rb
index f4814f1c42..6ba7464203 100644
--- a/activerecord/test/cases/transactions_test.rb
+++ b/activerecord/test/cases/transactions_test.rb
@@ -593,14 +593,5 @@ if current_adapter?(:PostgreSQLAdapter)
assert_equal original_salary, Developer.find(1).salary
end
-
- test "#transaction_joinable= is deprecated" do
- Developer.transaction do
- conn = Developer.connection
- assert conn.current_transaction.joinable?
- assert_deprecated { conn.transaction_joinable = false }
- assert !conn.current_transaction.joinable?
- end
- end
end
end