diff options
author | Edouard CHIN <edouard.chin@shopify.com> | 2018-01-16 15:45:18 -0500 |
---|---|---|
committer | Edouard CHIN <edouard.chin@shopify.com> | 2018-01-17 15:03:22 -0500 |
commit | 84206ad38750840431ea0cbc490177ad61b11bfc (patch) | |
tree | 8933fc72ed8d3febb5a031d117b5f1b843f38251 /activerecord | |
parent | 07563036b0b5c5ddf5b1a31473aa2a2b32b608f5 (diff) | |
download | rails-84206ad38750840431ea0cbc490177ad61b11bfc.tar.gz rails-84206ad38750840431ea0cbc490177ad61b11bfc.tar.bz2 rails-84206ad38750840431ea0cbc490177ad61b11bfc.zip |
Added a test around `NO_AUTO_VALUE_ON_ZERO`:
- The mysql `NO_AUTO_VALUE_ON_ZERO` mode should be disabled when inserting fixtures in bulk, this PR adds a test to make sure we don't remove it by mistake
- If we live this mode enabled, a statement like this wouldn't work and a `Duplicate entry '0' for key 'PRIMARY'` error will be raised. That's because `DEFAULT` on auto_increment will return 0
```sql
INSERT INTO `aircraft` (`id`, `name`, `wheels_count`) VALUES (DEFAULT, 'first', 2), (DEFAULT, 'second', 3)
```
Diffstat (limited to 'activerecord')
-rw-r--r-- | activerecord/test/cases/fixtures_test.rb | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/activerecord/test/cases/fixtures_test.rb b/activerecord/test/cases/fixtures_test.rb index 8e8a49af8e..d692c0eccb 100644 --- a/activerecord/test/cases/fixtures_test.rb +++ b/activerecord/test/cases/fixtures_test.rb @@ -81,6 +81,28 @@ class FixturesTest < ActiveRecord::TestCase end end + def test_no_auto_value_on_zero_is_disabled + skip unless current_adapter?(:Mysql2Adapter) + + begin + fixtures = [ + { "name" => "first", "wheels_count" => 2 }, + { "name" => "second", "wheels_count" => 3 } + ] + subscriber = InsertQuerySubscriber.new + subscription = ActiveSupport::Notifications.subscribe("sql.active_record", subscriber) + + assert_nothing_raised do + ActiveRecord::Base.connection.insert_fixtures(fixtures, "aircraft") + end + + expected_sql = "INSERT INTO `aircraft` (`id`, `name`, `wheels_count`) VALUES (DEFAULT, 'first', 2), (DEFAULT, 'second', 3)" + assert_equal expected_sql, subscriber.events.first + ensure + ActiveSupport::Notifications.unsubscribe(subscription) + end + end + def test_broken_yaml_exception badyaml = Tempfile.new ["foo", ".yml"] badyaml.write "a: : " |