aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-02-17 08:52:52 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-02-17 08:52:52 +0900
commit7f45c2d02a732cc724a021fd5907c1f00b7e1fe9 (patch)
tree6b2b8cd6a7ec57c1087df5c5db200a6640ebe30d /activerecord
parent6dccceef9c888e7e8a2cdcd46cd896eff75d64d9 (diff)
downloadrails-7f45c2d02a732cc724a021fd5907c1f00b7e1fe9.tar.gz
rails-7f45c2d02a732cc724a021fd5907c1f00b7e1fe9.tar.bz2
rails-7f45c2d02a732cc724a021fd5907c1f00b7e1fe9.zip
Add CHANGELOG entry for #27384 and #27762
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/CHANGELOG.md4
-rw-r--r--activerecord/test/cases/primary_keys_test.rb8
2 files changed, 8 insertions, 4 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 116363f2d9..c1f39958b7 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+* All integer-like PKs are autoincrement unless they have an explicit default.
+
+ *Matthew Draper*
+
* Omit redundant `using: :btree` for schema dumping.
*Ryuta Kamizono*
diff --git a/activerecord/test/cases/primary_keys_test.rb b/activerecord/test/cases/primary_keys_test.rb
index 98b9c91489..03c8644229 100644
--- a/activerecord/test/cases/primary_keys_test.rb
+++ b/activerecord/test/cases/primary_keys_test.rb
@@ -238,13 +238,13 @@ class PrimaryKeyWithAutoIncrementTest < ActiveRecord::TestCase
@connection.drop_table(:auto_increments, if_exists: true)
end
- def test_primary_key_with_auto_increment
- @connection.create_table(:auto_increments, id: :integer, auto_increment: true, force: true)
+ def test_primary_key_with_integer
+ @connection.create_table(:auto_increments, id: :integer, force: true)
assert_auto_incremented
end
- def test_primary_key_with_auto_increment_and_bigint
- @connection.create_table(:auto_increments, id: :bigint, auto_increment: true, force: true)
+ def test_primary_key_with_bigint
+ @connection.create_table(:auto_increments, id: :bigint, force: true)
assert_auto_incremented
end