diff options
author | Yves Senn <yves.senn@gmail.com> | 2014-01-21 14:35:33 +0100 |
---|---|---|
committer | Yves Senn <yves.senn@gmail.com> | 2014-01-21 14:35:33 +0100 |
commit | 6f0aa1d64dafd72275c934ed14529ccfada55d1d (patch) | |
tree | bcadb020fb95f7e838cccdb4402ed0c7b4e08e9e /activerecord | |
parent | 6a8a7f89aee25042b795fbfc8689a6db05549c7d (diff) | |
download | rails-6f0aa1d64dafd72275c934ed14529ccfada55d1d.tar.gz rails-6f0aa1d64dafd72275c934ed14529ccfada55d1d.tar.bz2 rails-6f0aa1d64dafd72275c934ed14529ccfada55d1d.zip |
Active Record changelog wording and formatting. [ci skip]
Diffstat (limited to 'activerecord')
-rw-r--r-- | activerecord/CHANGELOG.md | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 3ca689e713..25a61b3614 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,8 +1,9 @@ * Fail early with "Primary key not included in the custom select clause" - in find_in_batches. + in `find_in_batches`. - Before this patch find_in_batches raises this error only on second iteration. - So you will know about the problem only when you get the batch size threshold. + Before this patch, the exception was raised after the first batch was + yielded to the block. This means that you only get it, when you hit the + `batch_size` treshold. This could shadow the issue in development. *Alexander Balashov* @@ -13,6 +14,8 @@ full-fledged finders in ActiveRecord. The biggest benefit of this is ordering of the records returned now defaults to the table's primary key in ascending order. + Fixes #13743. + Example: User.all.second @@ -33,8 +36,6 @@ # After # => SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1 OFFSET 4' - Fixes #13743. - *Jason Meller* * ActiveRecord states are now correctly restored after a rollback for |