diff options
| author | Eugene Kenny <elkenny@gmail.com> | 2017-12-20 01:09:23 +0000 |
|---|---|---|
| committer | Eugene Kenny <elkenny@gmail.com> | 2017-12-20 01:09:23 +0000 |
| commit | 69d5a7439376401a6c832504aa73686e93da1bd3 (patch) | |
| tree | 6c75bdb13cef872da33fd65661ac480e8c0eb12d /activerecord | |
| parent | 08b9d8b3e05ef07a8f16245446cb62ca4f265dbb (diff) | |
| download | rails-69d5a7439376401a6c832504aa73686e93da1bd3.tar.gz rails-69d5a7439376401a6c832504aa73686e93da1bd3.tar.bz2 rails-69d5a7439376401a6c832504aa73686e93da1bd3.zip | |
Remove verbose_query_logs from new_framework_defaults_5_2.rb
The `app:update` rake task will regenerate `development.rb` so that it
contains this option; that means we're currently adding it to existing
apps in two places, which is unnecessary and confusing.
Also:
- Remove inaccurate comment about which stack frames are ignored
- Clarify that the feature uses `caller_locations`, not `caller`
- Remove unused return value in `extract_callstack`
Diffstat (limited to 'activerecord')
| -rw-r--r-- | activerecord/CHANGELOG.md | 4 | ||||
| -rw-r--r-- | activerecord/lib/active_record/log_subscriber.rb | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index d5cce3f47c..791de1f2d0 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -15,11 +15,11 @@ Add `verbose_query_logs` configuration option to display the caller of database queries in the log to facilitate N+1 query resolution - and other debugging. Excludes Ruby and Rails callers but not gems. + and other debugging. Enabled in development only for new and upgraded applications. Not recommended for use in the production environment since it relies - on Ruby's `Kernel#caller` which is fairly slow. + on Ruby's `Kernel#caller_locations` which is fairly slow. *Olivier Lacan* diff --git a/activerecord/lib/active_record/log_subscriber.rb b/activerecord/lib/active_record/log_subscriber.rb index ba3419be6c..9234029c22 100644 --- a/activerecord/lib/active_record/log_subscriber.rb +++ b/activerecord/lib/active_record/log_subscriber.rb @@ -121,8 +121,7 @@ module ActiveRecord [ offending_line.path, - offending_line.lineno, - offending_line.label + offending_line.lineno ] end |