aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorYasuo Honda <yasuo.honda@gmail.com>2019-03-03 03:10:36 +0000
committerYasuo Honda <yasuo.honda@gmail.com>2019-03-03 03:18:31 +0000
commit2820c90a918b0eb714b90d260bf43eb22ad31ef9 (patch)
treef164c2edbefb5426aaba434b36b3d31583b01d47 /activerecord
parentf4a30d2a0706f278a20c63a3d99288de79b52e5f (diff)
downloadrails-2820c90a918b0eb714b90d260bf43eb22ad31ef9.tar.gz
rails-2820c90a918b0eb714b90d260bf43eb22ad31ef9.tar.bz2
rails-2820c90a918b0eb714b90d260bf43eb22ad31ef9.zip
Oracle 12.2+ supports 128 byte identifier length
```ruby $ ARCONN=oracle bin/test test/cases/migration/columns_test.rb -n test_rename_column_with_multi_column_index ... snip ... F Failure: ActiveRecord::Migration::ColumnsTest#test_rename_column_with_multi_column_index [/home/yahonda/git/rails/activerecord/test/cases/migration/columns_test.rb:113]: --- expected +++ actual @@ -1 +1 @@ -["i_test_models_hat_style_size"] +["index_test_models_on_hat_style_and_size"] ``` Kind of reverting #9395 Refer https://github.com/rsim/oracle-enhanced/pull/1703
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/test/cases/migration/columns_test.rb12
1 files changed, 2 insertions, 10 deletions
diff --git a/activerecord/test/cases/migration/columns_test.rb b/activerecord/test/cases/migration/columns_test.rb
index 1c66c8186f..dbbba9c5fa 100644
--- a/activerecord/test/cases/migration/columns_test.rb
+++ b/activerecord/test/cases/migration/columns_test.rb
@@ -109,18 +109,10 @@ module ActiveRecord
add_index "test_models", ["hat_style", "hat_size"], unique: true
rename_column "test_models", "hat_size", "size"
- if current_adapter? :OracleAdapter
- assert_equal ["i_test_models_hat_style_size"], connection.indexes("test_models").map(&:name)
- else
- assert_equal ["index_test_models_on_hat_style_and_size"], connection.indexes("test_models").map(&:name)
- end
+ assert_equal ["index_test_models_on_hat_style_and_size"], connection.indexes("test_models").map(&:name)
rename_column "test_models", "hat_style", "style"
- if current_adapter? :OracleAdapter
- assert_equal ["i_test_models_style_size"], connection.indexes("test_models").map(&:name)
- else
- assert_equal ["index_test_models_on_style_and_size"], connection.indexes("test_models").map(&:name)
- end
+ assert_equal ["index_test_models_on_style_and_size"], connection.indexes("test_models").map(&:name)
end
def test_rename_column_does_not_rename_custom_named_index