aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorAndrew White <andrew.white@unboxed.co>2017-03-04 11:15:00 +0000
committerAndrew White <andrew.white@unboxed.co>2017-03-04 11:16:17 +0000
commit21ff8a493206cd50558b03975a7eaaaeb6ec7900 (patch)
tree1de5aa53f10f74b04fc9b9acbc43fb8af253120a /activerecord
parentd341a47fcc74be74b16798c62e95021fc2893ba4 (diff)
downloadrails-21ff8a493206cd50558b03975a7eaaaeb6ec7900.tar.gz
rails-21ff8a493206cd50558b03975a7eaaaeb6ec7900.tar.bz2
rails-21ff8a493206cd50558b03975a7eaaaeb6ec7900.zip
[ci skip] Add CHANGELOG entry for #28282
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/CHANGELOG.md10
1 files changed, 10 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 55773f2172..8d054a144a 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,13 @@
+* Don't share options between reference id and type columns
+
+ When using a polymorphic reference column in a migration, sharing options
+ between the two columns doesn't make sense since they are different types.
+ The `reference_id` column is usually an integer and the `reference_type`
+ column a string so options like `unsigned: true` will result in an invalid
+ table definition.
+
+ *Ryuta Kamizono*
+
* Use `max_identifier_length` for `index_name_length` in PostgreSQL adapter.
*Ryuta Kamizono*