aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorPratik Naik <pratiknaik@gmail.com>2010-01-20 20:37:03 +0530
committerPratik Naik <pratiknaik@gmail.com>2010-01-20 20:37:17 +0530
commit1fb78e3ed8142782f19877a195f10b1828dd672c (patch)
treee238f03953887377cde44d48c192b229b439cf04 /activerecord
parent909443eab67c4f07aeb6a294e3858792f075b3ab (diff)
downloadrails-1fb78e3ed8142782f19877a195f10b1828dd672c.tar.gz
rails-1fb78e3ed8142782f19877a195f10b1828dd672c.tar.bz2
rails-1fb78e3ed8142782f19877a195f10b1828dd672c.zip
Base.merge_conditions is no longer needed
Diffstat (limited to 'activerecord')
-rwxr-xr-xactiverecord/lib/active_record/base.rb14
-rw-r--r--activerecord/lib/active_record/relation/query_methods.rb4
2 files changed, 2 insertions, 16 deletions
diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb
index 45edc3fe60..f71ccb3a51 100755
--- a/activerecord/lib/active_record/base.rb
+++ b/activerecord/lib/active_record/base.rb
@@ -1238,20 +1238,6 @@ module ActiveRecord #:nodoc:
store_full_sti_class ? name : name.demodulize
end
- # Merges conditions so that the result is a valid +condition+
- def merge_conditions(*conditions)
- segments = []
-
- conditions.each do |condition|
- unless condition.blank?
- sql = sanitize_sql(condition)
- segments << sql unless sql.blank?
- end
- end
-
- "(#{segments.join(') AND (')})" unless segments.empty?
- end
-
def unscoped
@unscoped ||= Relation.new(self, arel_table)
finder_needs_type_condition? ? @unscoped.where(type_condition) : @unscoped
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb
index 163d698b5c..bad6fd716b 100644
--- a/activerecord/lib/active_record/relation/query_methods.rb
+++ b/activerecord/lib/active_record/relation/query_methods.rb
@@ -167,8 +167,8 @@ module ActiveRecord
builder = PredicateBuilder.new(table.engine)
conditions = if [String, Array].include?(args.first.class)
- merged = @klass.send(:merge_conditions, args.size > 1 ? Array.wrap(args) : args.first)
- Arel::SqlLiteral.new(merged) if merged
+ sql = @klass.send(:sanitize_sql, args.size > 1 ? args : args.first)
+ Arel::SqlLiteral.new("(#{sql})") if sql.present?
elsif args.first.is_a?(Hash)
attributes = @klass.send(:expand_hash_conditions_for_aggregates, args.first)
builder.build_from_hash(attributes, table)