aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorMarcel Molina <marcel@vernix.org>2005-09-26 21:55:37 +0000
committerMarcel Molina <marcel@vernix.org>2005-09-26 21:55:37 +0000
commit1d738cab80b497f13ef6cfca1a658c6400609698 (patch)
tree10eee8abc868fde7cfe5638de06e73270b9ceb2d /activerecord
parent1465f9cee27a55b5c13bad35bac74be119097f17 (diff)
downloadrails-1d738cab80b497f13ef6cfca1a658c6400609698.tar.gz
rails-1d738cab80b497f13ef6cfca1a658c6400609698.tar.bz2
rails-1d738cab80b497f13ef6cfca1a658c6400609698.zip
Make update_attribute use the same writer method that update_attributes uses.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/CHANGELOG3
-rwxr-xr-xactiverecord/lib/active_record/base.rb2
-rwxr-xr-xactiverecord/lib/active_record/validations.rb2
3 files changed, 5 insertions, 2 deletions
diff --git a/activerecord/CHANGELOG b/activerecord/CHANGELOG
index c4336025c3..2542e46ac3 100644
--- a/activerecord/CHANGELOG
+++ b/activerecord/CHANGELOG
@@ -1,5 +1,8 @@
*SVN*
+* Make update_attribute use the same writer method that update_attributes uses.
+ #2237 [trevor@protocool.com]
+
* Make migrations honor table name prefixes and suffixes. #2298 [Jakob S, Marcel Molina]
* Correct and optimize PostgreSQL bytea escaping. #1745, #1837 [dave@cherryville.org, ken@miriamtech.com, bellis@deepthought.org]
diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb
index 6f655df26f..37ed2071cf 100755
--- a/activerecord/lib/active_record/base.rb
+++ b/activerecord/lib/active_record/base.rb
@@ -1057,7 +1057,7 @@ module ActiveRecord #:nodoc:
# Note: This method is overwritten by the Validation module that'll make sure that updates made with this method
# doesn't get subjected to validation checks. Hence, attributes can be updated even if the full object isn't valid.
def update_attribute(name, value)
- self[name] = value
+ send(name.to_s + '=', value)
save
end
diff --git a/activerecord/lib/active_record/validations.rb b/activerecord/lib/active_record/validations.rb
index 6481e37a25..8f407b25c3 100755
--- a/activerecord/lib/active_record/validations.rb
+++ b/activerecord/lib/active_record/validations.rb
@@ -661,7 +661,7 @@ module ActiveRecord
# This is especially useful for boolean flags on existing records. The regular +update_attribute+ method
# in Base is replaced with this when the validations module is mixed in, which it is by default.
def update_attribute_with_validation_skipping(name, value)
- self[name] = value
+ send(name.to_s + '=', value)
save(false)
end