aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2016-11-19 18:02:04 +0100
committerGitHub <noreply@github.com>2016-11-19 18:02:04 +0100
commit1cf995688d8df0bc4a473a0e41dc2240e413bb44 (patch)
tree2697ab28933b0fcd7d1de04012ce645f02972dc1 /activerecord
parent4aacace550155faab98710c045f912db80601004 (diff)
parent7b6b52d6bcd204aaddcdc36481956d73a54ea7bb (diff)
downloadrails-1cf995688d8df0bc4a473a0e41dc2240e413bb44.tar.gz
rails-1cf995688d8df0bc4a473a0e41dc2240e413bb44.tar.bz2
rails-1cf995688d8df0bc4a473a0e41dc2240e413bb44.zip
Merge pull request #27109 from prathamesh-sonpatki/fix-prepared-statements-test
Fix tests for prepared_statements: false and queries hitting `#select_all`
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb8
-rw-r--r--activerecord/test/config.example.yml3
-rw-r--r--activerecord/test/support/config.rb3
3 files changed, 9 insertions, 5 deletions
diff --git a/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb b/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb
index 181c1a097c..1214b28366 100644
--- a/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb
+++ b/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb
@@ -6,17 +6,17 @@ class PreparedStatementsTest < ActiveRecord::PostgreSQLTestCase
fixtures :developers
def setup
- @default_prepared_statements = ActiveRecord::Base.connection.instance_variable_get("@prepared_statements")
- ActiveRecord::Base.connection.instance_variable_set("@prepared_statements", false)
+ @conn = ActiveRecord::Base.establish_connection :arunit_with_prepared_statements
end
def teardown
- ActiveRecord::Base.connection.instance_variable_set("@prepared_statements", @default_prepared_statements)
+ @conn.release_connection
+ ActiveRecord::Base.establish_connection :arunit
end
def test_nothing_raised_with_falsy_prepared_statements
assert_nothing_raised do
- Developer.where(id: 1)
+ Developer.where(id: 1).to_a
end
end
end
diff --git a/activerecord/test/config.example.yml b/activerecord/test/config.example.yml
index 58e2d45748..4bcb2aeea6 100644
--- a/activerecord/test/config.example.yml
+++ b/activerecord/test/config.example.yml
@@ -77,6 +77,9 @@ connections:
postgresql:
arunit:
min_messages: warning
+ arunit_without_prepared_statements:
+ min_messages: warning
+ prepared_statements: false
arunit2:
min_messages: warning
diff --git a/activerecord/test/support/config.rb b/activerecord/test/support/config.rb
index 5817e427e3..e1aa8d72e3 100644
--- a/activerecord/test/support/config.rb
+++ b/activerecord/test/support/config.rb
@@ -26,7 +26,8 @@ module ARTest
def expand_config(config)
config["connections"].each do |adapter, connection|
- dbs = [["arunit", "activerecord_unittest"], ["arunit2", "activerecord_unittest2"]]
+ dbs = [["arunit", "activerecord_unittest"], ["arunit2", "activerecord_unittest2"],
+ ["arunit_with_prepared_statements", "activerecord_unittest"]]
dbs.each do |name, dbname|
unless connection[name].is_a?(Hash)
connection[name] = { "database" => connection[name] }