Don't skip tests if they are not broken. Just don't define they

2 files changed, 5 insertions, 9 deletions

diff --git a/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb b/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
index 02834edf7b..73cb739b2b 100644
--- a/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
+++ b/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
@@ -33,9 +33,8 @@ module ActiveRecord
         end
       end
 
-      def test_connect_with_url
-        skip "can't establish new connection when using memory db" if in_memory_db?
-        begin
+      unless in_memory_db?
+        def test_connect_with_url
           original_connection = ActiveRecord::Base.remove_connection
           tf = Tempfile.open 'whatever'
           url = "sqlite3://#{tf.path}"
@@ -46,11 +45,8 @@ module ActiveRecord
           tf.unlink
           ActiveRecord::Base.establish_connection(original_connection)
         end
-      end
 
-      def test_connect_memory_with_url
-        skip "can't establish new connection when using memory db" if in_memory_db?
-        begin
+        def test_connect_memory_with_url
           original_connection = ActiveRecord::Base.remove_connection
           url = "sqlite3:///:memory:"
           ActiveRecord::Base.establish_connection(url)
diff --git a/activerecord/test/cases/associations/eager_singularization_test.rb b/activerecord/test/cases/associations/eager_singularization_test.rb
index 669569a774..b12bc355e8 100644
--- a/activerecord/test/cases/associations/eager_singularization_test.rb
+++ b/activerecord/test/cases/associations/eager_singularization_test.rb
@@ -1,6 +1,7 @@
 require "cases/helper"
 
 
+if ActiveRecord::Base.connection.supports_migrations?
 class EagerSingularizationTest < ActiveRecord::TestCase
   class Virus < ActiveRecord::Base
     belongs_to :octopus
@@ -50,8 +51,6 @@ class EagerSingularizationTest < ActiveRecord::TestCase
   end
 
   def setup
-    skip 'Does not support migrations' unless connection.supports_migrations?
-
     connection.create_table :viri do |t|
       t.column :octopus_id, :integer
       t.column :species, :string
@@ -146,3 +145,4 @@ class EagerSingularizationTest < ActiveRecord::TestCase
     end
   end
 end
+end