aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2017-03-09 13:53:51 -0500
committerRafael Mendonça França <rafaelmfranca@gmail.com>2017-03-09 13:53:51 -0500
commit0c19d97939161b907bef6e33024def25f98eb361 (patch)
tree45af4e50e5db02f3d0b7a55a73619023d84704fc /activerecord
parentc77cbaff49218db7e5fe93cffc2f5333e63a99c9 (diff)
parent96aa18974adf7321f265eafbdfe74c7c6e007cb0 (diff)
downloadrails-0c19d97939161b907bef6e33024def25f98eb361.tar.gz
rails-0c19d97939161b907bef6e33024def25f98eb361.tar.bz2
rails-0c19d97939161b907bef6e33024def25f98eb361.zip
Merge pull request #28351 from kamipo/deprecate_schema_migrations_table_name
Deprecate `Migrator.schema_migrations_table_name`
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/CHANGELOG.md4
-rw-r--r--activerecord/lib/active_record/migration.rb5
-rw-r--r--activerecord/test/cases/migration_test.rb4
3 files changed, 13 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 9d20e59745..a59f38fd69 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Deprecate `Migrator.schema_migrations_table_name`.
+
+ *Ryuta Kamizono*
+
* Fix select with block doesn't return newly built records in has_many association.
Fixes #28348.
diff --git a/activerecord/lib/active_record/migration.rb b/activerecord/lib/active_record/migration.rb
index 3eb9171a5f..4e1df1432c 100644
--- a/activerecord/lib/active_record/migration.rb
+++ b/activerecord/lib/active_record/migration.rb
@@ -1022,6 +1022,11 @@ module ActiveRecord
new(:up, migrations(migrations_paths), nil)
end
+ def schema_migrations_table_name
+ SchemaMigration.table_name
+ end
+ deprecate :schema_migrations_table_name
+
def get_all_versions(connection = Base.connection)
if SchemaMigration.table_exists?
SchemaMigration.all_versions.map(&:to_i)
diff --git a/activerecord/test/cases/migration_test.rb b/activerecord/test/cases/migration_test.rb
index 744fa865be..da7875187a 100644
--- a/activerecord/test/cases/migration_test.rb
+++ b/activerecord/test/cases/migration_test.rb
@@ -1146,4 +1146,8 @@ class CopyMigrationsTest < ActiveRecord::TestCase
def test_deprecate_supports_migrations
assert_deprecated { ActiveRecord::Base.connection.supports_migrations? }
end
+
+ def test_deprecate_schema_migrations_table_name
+ assert_deprecated { ActiveRecord::Migrator.schema_migrations_table_name }
+ end
end