aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-12-20 13:35:49 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-12-20 13:35:49 +0900
commit0aa0de17488be8c3490b5f230f8186dd744fa90d (patch)
tree9c8d75917fa24e11913328502ad3f84bfb953059 /activerecord
parenta8cabf3b2a8057414b291ce492cf6d15107cd652 (diff)
downloadrails-0aa0de17488be8c3490b5f230f8186dd744fa90d.tar.gz
rails-0aa0de17488be8c3490b5f230f8186dd744fa90d.tar.bz2
rails-0aa0de17488be8c3490b5f230f8186dd744fa90d.zip
Place args normalization from `left_outer_joins` to `left_outer_joins!`
Like other query bang methods.
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/lib/active_record/relation/query_methods.rb6
1 files changed, 2 insertions, 4 deletions
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb
index 2056f9bb73..0296101f81 100644
--- a/activerecord/lib/active_record/relation/query_methods.rb
+++ b/activerecord/lib/active_record/relation/query_methods.rb
@@ -444,15 +444,13 @@ module ActiveRecord
#
def left_outer_joins(*args)
check_if_method_has_arguments!(__callee__, args)
-
- args.compact!
- args.flatten!
-
spawn.left_outer_joins!(*args)
end
alias :left_joins :left_outer_joins
def left_outer_joins!(*args) # :nodoc:
+ args.compact!
+ args.flatten!
self.left_outer_joins_values += args
self
end