aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorEdo Balvers <i@edo.me>2013-11-16 21:18:02 +0100
committerEdo Balvers <i@edo.me>2013-11-16 21:18:02 +0100
commit02ca5580bd5f70dbd5ffcd147da6b99e2c90c265 (patch)
treef0a96848b21fea2aa3eac07bd9e564ca5de77b11 /activerecord
parent1dfe05f98eaa0b8067fa1dfd019d44c851879b22 (diff)
downloadrails-02ca5580bd5f70dbd5ffcd147da6b99e2c90c265.tar.gz
rails-02ca5580bd5f70dbd5ffcd147da6b99e2c90c265.tar.bz2
rails-02ca5580bd5f70dbd5ffcd147da6b99e2c90c265.zip
Checks to see if the record contains the foreign_key to set the inverse automatically
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/CHANGELOG.md4
-rw-r--r--activerecord/lib/active_record/associations/association.rb7
-rw-r--r--activerecord/test/cases/associations/has_many_associations_test.rb4
3 files changed, 14 insertions, 1 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 0497f6326e..fa5164521c 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Checks to see if the record contains the foreign_key to set the inverse automatically
+
+ *Edo Balvers*
+
* `.unscope` now removes conditions specified in `default_scope`.
*Jon Leighton*
diff --git a/activerecord/lib/active_record/associations/association.rb b/activerecord/lib/active_record/associations/association.rb
index e6a45487d0..02f45731c9 100644
--- a/activerecord/lib/active_record/associations/association.rb
+++ b/activerecord/lib/active_record/associations/association.rb
@@ -226,7 +226,12 @@ module ActiveRecord
# Returns true if inverse association on the given record needs to be set.
# This method is redefined by subclasses.
def invertible_for?(record)
- inverse_reflection_for(record)
+ foreign_key_for?(record) && inverse_reflection_for(record)
+ end
+
+ # Returns true if record contains the foreign_key
+ def foreign_key_for?(record)
+ record.attributes.has_key? reflection.foreign_key
end
# This should be implemented to return the values of the relevant key(s) on the owner,
diff --git a/activerecord/test/cases/associations/has_many_associations_test.rb b/activerecord/test/cases/associations/has_many_associations_test.rb
index dfc8a68e8c..b11d27467b 100644
--- a/activerecord/test/cases/associations/has_many_associations_test.rb
+++ b/activerecord/test/cases/associations/has_many_associations_test.rb
@@ -460,6 +460,10 @@ class HasManyAssociationsTest < ActiveRecord::TestCase
assert_equal ['id'], posts(:welcome).comments.select(:id).first.attributes.keys
end
+ def test_select_without_foreign_key
+ assert_equal companies(:first_firm).accounts.first.credit_limit, companies(:first_firm).accounts.select(:credit_limit).first.credit_limit
+ end
+
def test_adding
force_signal37_to_load_all_clients_of_firm
natural = Client.new("name" => "Natural Company")