aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
diff options
context:
space:
mode:
authorEileen M. Uchitelle <eileencodes@users.noreply.github.com>2019-07-10 14:05:22 -0500
committerGitHub <noreply@github.com>2019-07-10 14:05:22 -0500
commitf4a094af8aed357e9acbe6b106519ede57ff2ee6 (patch)
tree2582cd20725f02a6e3af74d8613b8e16526ffffc /activerecord/test
parent2fe20cb55c76e6e50ec3a4ec5b03bbb65adba290 (diff)
parent10ed7f580ebdfe53848424268455257c9eb729c6 (diff)
downloadrails-f4a094af8aed357e9acbe6b106519ede57ff2ee6.tar.gz
rails-f4a094af8aed357e9acbe6b106519ede57ff2ee6.tar.bz2
rails-f4a094af8aed357e9acbe6b106519ede57ff2ee6.zip
Merge pull request #36618 from engwan/fix-query-cache-with-shared-ar-connection
Fix query cache when using shared connections
Diffstat (limited to 'activerecord/test')
-rw-r--r--activerecord/test/cases/query_cache_test.rb17
1 files changed, 17 insertions, 0 deletions
diff --git a/activerecord/test/cases/query_cache_test.rb b/activerecord/test/cases/query_cache_test.rb
index 53a4963909..79bd6906d1 100644
--- a/activerecord/test/cases/query_cache_test.rb
+++ b/activerecord/test/cases/query_cache_test.rb
@@ -536,6 +536,23 @@ class QueryCacheTest < ActiveRecord::TestCase
ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler }
end
+ test "query cache is enabled in threads with shared connection" do
+ ActiveRecord::Base.connection_pool.lock_thread = true
+
+ assert_cache :off
+
+ thread_a = Thread.new do
+ middleware { |env|
+ assert_cache :clean
+ [200, {}, nil]
+ }.call({})
+ end
+
+ thread_a.join
+
+ ActiveRecord::Base.connection_pool.lock_thread = false
+ end
+
private
def with_temporary_connection_pool
old_pool = ActiveRecord::Base.connection_handler.retrieve_connection_pool(ActiveRecord::Base.connection_specification_name)