aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
diff options
context:
space:
mode:
authorSantiago Pastorino <santiago@wyeworks.com>2012-09-21 19:10:16 -0300
committerSantiago Pastorino <santiago@wyeworks.com>2012-09-21 19:14:17 -0300
commiteb876c4d07130f15be2cac7be968cc393f959c62 (patch)
tree04914044df46ba84862b381052d025d2d7f1ac73 /activerecord/test
parent008eaebb562af7d95907b46e3d734312c795b2e0 (diff)
downloadrails-eb876c4d07130f15be2cac7be968cc393f959c62.tar.gz
rails-eb876c4d07130f15be2cac7be968cc393f959c62.tar.bz2
rails-eb876c4d07130f15be2cac7be968cc393f959c62.zip
Revert "Fix find_in_batches with customized primary_key"
This reverts commit 761bc751d31c22e2c2fdae2b4cdd435b68b6d783. This commit wasn't fixing any issue just using the same table for different models with different primary keys.
Diffstat (limited to 'activerecord/test')
-rw-r--r--activerecord/test/cases/batches_test.rb6
-rw-r--r--activerecord/test/models/post.rb5
2 files changed, 5 insertions, 6 deletions
diff --git a/activerecord/test/cases/batches_test.rb b/activerecord/test/cases/batches_test.rb
index 3b4ff83725..78d89aa232 100644
--- a/activerecord/test/cases/batches_test.rb
+++ b/activerecord/test/cases/batches_test.rb
@@ -125,14 +125,18 @@ class EachTest < ActiveRecord::TestCase
end
def test_find_in_batches_should_use_any_column_as_primary_key
+ old_primary_key = Post.primary_key
+ Post.primary_key = :title
title_order_posts = Post.order('title asc')
start_title = title_order_posts.first.title
posts = []
- PostWithTitlePrimaryKey.find_in_batches(:batch_size => 1, :start => start_title) do |batch|
+ Post.find_in_batches(:batch_size => 1, :start => start_title) do |batch|
posts.concat(batch)
end
assert_equal title_order_posts.map(&:id), posts.map(&:id)
+ ensure
+ Post.primary_key = old_primary_key
end
end
diff --git a/activerecord/test/models/post.rb b/activerecord/test/models/post.rb
index 9858f68c4a..c995f59a15 100644
--- a/activerecord/test/models/post.rb
+++ b/activerecord/test/models/post.rb
@@ -186,8 +186,3 @@ class SpecialPostWithDefaultScope < ActiveRecord::Base
self.table_name = 'posts'
default_scope { where(:id => [1, 5,6]) }
end
-
-class PostWithTitlePrimaryKey < ActiveRecord::Base
- self.table_name = 'posts'
- self.primary_key = :title
-end