diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2019-01-09 18:09:01 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-01-09 18:09:01 +0900 |
| commit | ea65d92f1924648e72f93bb0e8e5fc62a56d0bac (patch) | |
| tree | 9e8ebde83d6f1fd2c0eaff195ee54c3f42e3ae88 /activerecord/test | |
| parent | 69ca787bd26c0306cdfde25de76036686fc39f4f (diff) | |
| download | rails-ea65d92f1924648e72f93bb0e8e5fc62a56d0bac.tar.gz rails-ea65d92f1924648e72f93bb0e8e5fc62a56d0bac.tar.bz2 rails-ea65d92f1924648e72f93bb0e8e5fc62a56d0bac.zip | |
Enable `Lint/UselessAssignment` cop to avoid unused variable warnings (#34904)
* Enable `Lint/UselessAssignment` cop to avoid unused variable warnings
Since we've addressed the warning "assigned but unused variable"
frequently.
370537de05092aeea552146b42042833212a1acc
3040446cece8e7a6d9e29219e636e13f180a1e03
5ed618e192e9788094bd92c51255dda1c4fd0eae
76ebafe594fc23abc3764acc7a3758ca473799e5
And also, I've found the unused args in c1b14ad which raises no warnings
by the cop, it shows the value of the cop.
Diffstat (limited to 'activerecord/test')
| -rw-r--r-- | activerecord/test/cases/batches_test.rb | 2 | ||||
| -rw-r--r-- | activerecord/test/cases/counter_cache_test.rb | 2 | ||||
| -rw-r--r-- | activerecord/test/cases/inheritance_test.rb | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/activerecord/test/cases/batches_test.rb b/activerecord/test/cases/batches_test.rb index d21218a997..cf6e280898 100644 --- a/activerecord/test/cases/batches_test.rb +++ b/activerecord/test/cases/batches_test.rb @@ -430,7 +430,7 @@ class EachTest < ActiveRecord::TestCase assert_kind_of ActiveRecord::Relation, relation assert_kind_of Post, relation.first - relation = [not_a_post] * relation.count + [not_a_post] * relation.count end end end diff --git a/activerecord/test/cases/counter_cache_test.rb b/activerecord/test/cases/counter_cache_test.rb index 99d286dc52..cc4f86a0fb 100644 --- a/activerecord/test/cases/counter_cache_test.rb +++ b/activerecord/test/cases/counter_cache_test.rb @@ -144,7 +144,7 @@ class CounterCacheTest < ActiveRecord::TestCase test "update other counters on parent destroy" do david, joanna = dog_lovers(:david, :joanna) - joanna = joanna # squelch a warning + _ = joanna # squelch a warning assert_difference "joanna.reload.dogs_count", -1 do david.destroy diff --git a/activerecord/test/cases/inheritance_test.rb b/activerecord/test/cases/inheritance_test.rb index 3d3189900f..19655a2d38 100644 --- a/activerecord/test/cases/inheritance_test.rb +++ b/activerecord/test/cases/inheritance_test.rb @@ -240,7 +240,7 @@ class InheritanceTest < ActiveRecord::TestCase cabbage = vegetable.becomes!(Cabbage) assert_equal "Cabbage", cabbage.custom_type - vegetable = cabbage.becomes!(Vegetable) + cabbage.becomes!(Vegetable) assert_nil cabbage.custom_type end @@ -654,7 +654,7 @@ class InheritanceAttributeMappingTest < ActiveRecord::TestCase assert_equal ["omg_inheritance_attribute_mapping_test/company"], ActiveRecord::Base.connection.select_values("SELECT sponsorable_type FROM sponsors") - sponsor = Sponsor.first + sponsor = Sponsor.find(sponsor.id) assert_equal startup, sponsor.sponsorable end end |