diff options
author | DmitryTsepelev <dmitry.a.tsepelev@gmail.com> | 2018-11-26 11:12:42 +0300 |
---|---|---|
committer | DmitryTsepelev <dmitry.a.tsepelev@gmail.com> | 2018-11-27 16:30:26 +0300 |
commit | d34c1fc3d64e51f9aeecfbffefd843e744dfbeac (patch) | |
tree | 64ee1bded54ac99df7eb170b85faa7db0b410294 /activerecord/test | |
parent | b9c7305dbe57931a153a540d49ae5d469af61a14 (diff) | |
download | rails-d34c1fc3d64e51f9aeecfbffefd843e744dfbeac.tar.gz rails-d34c1fc3d64e51f9aeecfbffefd843e744dfbeac.tar.bz2 rails-d34c1fc3d64e51f9aeecfbffefd843e744dfbeac.zip |
Cached columns_hash fields should be excluded from ResultSet#column_types
Diffstat (limited to 'activerecord/test')
-rw-r--r-- | activerecord/test/cases/base_test.rb | 8 | ||||
-rw-r--r-- | activerecord/test/cases/instrumentation_test.rb | 4 | ||||
-rw-r--r-- | activerecord/test/models/developer.rb | 14 |
3 files changed, 26 insertions, 0 deletions
diff --git a/activerecord/test/cases/base_test.rb b/activerecord/test/cases/base_test.rb index 09e5517449..63a73101c4 100644 --- a/activerecord/test/cases/base_test.rb +++ b/activerecord/test/cases/base_test.rb @@ -1447,6 +1447,14 @@ class BasicsTest < ActiveRecord::TestCase assert_not_respond_to developer, :first_name= end + test "when ignored attribute is loaded, cast type should be preferred over DB type" do + developer = AttributedDeveloper.create + developer.update_column :name, "name" + + loaded_developer = AttributedDeveloper.where(id: developer.id).select("*").first + assert_equal "Developer: name", loaded_developer.name + end + test "ignored columns not included in SELECT" do query = Developer.all.to_sql.downcase diff --git a/activerecord/test/cases/instrumentation_test.rb b/activerecord/test/cases/instrumentation_test.rb index e6e8468757..c09ea32991 100644 --- a/activerecord/test/cases/instrumentation_test.rb +++ b/activerecord/test/cases/instrumentation_test.rb @@ -5,6 +5,10 @@ require "models/book" module ActiveRecord class InstrumentationTest < ActiveRecord::TestCase + def setup + ActiveRecord::Base.connection.schema_cache.add(Book.table_name) + end + def test_payload_name_on_load Book.create(name: "test book") subscriber = ActiveSupport::Notifications.subscribe("sql.active_record") do |*args| diff --git a/activerecord/test/models/developer.rb b/activerecord/test/models/developer.rb index 8881c69368..ec48094207 100644 --- a/activerecord/test/models/developer.rb +++ b/activerecord/test/models/developer.rb @@ -279,3 +279,17 @@ class DeveloperWithIncorrectlyOrderedHasManyThrough < ActiveRecord::Base has_many :companies, through: :contracts has_many :contracts, foreign_key: :developer_id end + +class DeveloperName < ActiveRecord::Type::String + def deserialize(value) + "Developer: #{value}" + end +end + +class AttributedDeveloper < ActiveRecord::Base + self.table_name = "developers" + + attribute :name, DeveloperName.new + + self.ignored_columns += ["name"] +end |