aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
diff options
context:
space:
mode:
authorTakashi Kokubun <takashikkbn@gmail.com>2015-10-31 01:04:23 +0900
committerTakashi Kokubun <takashikkbn@gmail.com>2015-10-31 01:37:35 +0900
commitd3411ad361bf1d02b1f9e1724c1298e7de3670ea (patch)
treeba35631d90691a08bfa1eba4ab7a6014702d5f09 /activerecord/test
parent6c61ae816ad7326e510a8f019cadc6db4cc9dae0 (diff)
downloadrails-d3411ad361bf1d02b1f9e1724c1298e7de3670ea.tar.gz
rails-d3411ad361bf1d02b1f9e1724c1298e7de3670ea.tar.bz2
rails-d3411ad361bf1d02b1f9e1724c1298e7de3670ea.zip
Alias left_joins to left_outer_joins
Diffstat (limited to 'activerecord/test')
-rw-r--r--activerecord/test/cases/associations/left_outer_join_association_test.rb5
-rw-r--r--activerecord/test/cases/relation/mutation_test.rb2
2 files changed, 6 insertions, 1 deletions
diff --git a/activerecord/test/cases/associations/left_outer_join_association_test.rb b/activerecord/test/cases/associations/left_outer_join_association_test.rb
index a362b43cc3..847292d5a0 100644
--- a/activerecord/test/cases/associations/left_outer_join_association_test.rb
+++ b/activerecord/test/cases/associations/left_outer_join_association_test.rb
@@ -29,6 +29,11 @@ class LeftOuterJoinAssociationTest < ActiveRecord::TestCase
assert_equal Author.count, Author.left_outer_joins(:posts).count
end
+ def test_left_outer_join_by_left_joins
+ assert_not_equal Author.count, Author.joins(:posts).count
+ assert_equal Author.count, Author.left_joins(:posts).count
+ end
+
def test_construct_finder_sql_ignores_empty_left_outer_joins_hash
sql = capture_sql { Author.left_outer_joins({}) }.first
assert_no_match(/LEFT OUTER JOIN/i, sql)
diff --git a/activerecord/test/cases/relation/mutation_test.rb b/activerecord/test/cases/relation/mutation_test.rb
index 88d2dd55ab..cc0034ffd1 100644
--- a/activerecord/test/cases/relation/mutation_test.rb
+++ b/activerecord/test/cases/relation/mutation_test.rb
@@ -28,7 +28,7 @@ module ActiveRecord
@relation ||= Relation.new FakeKlass.new('posts'), Post.arel_table, Post.predicate_builder
end
- (Relation::MULTI_VALUE_METHODS - [:references, :extending, :order, :unscope, :select]).each do |method|
+ (Relation::MULTI_VALUE_METHODS - [:references, :extending, :order, :unscope, :select, :left_joins]).each do |method|
test "##{method}!" do
assert relation.public_send("#{method}!", :foo).equal?(relation)
assert_equal [:foo], relation.public_send("#{method}_values")