Merge pull request #16034 from sgrif/sg-hstore-type-object

Use the type object for type casting HStore columns

1 files changed, 5 insertions, 11 deletions

diff --git a/activerecord/test/cases/adapters/postgresql/hstore_test.rb b/activerecord/test/cases/adapters/postgresql/hstore_test.rb
index 8f78dbecf5..2631b6a939 100644
--- a/activerecord/test/cases/adapters/postgresql/hstore_test.rb
+++ b/activerecord/test/cases/adapters/postgresql/hstore_test.rb
@@ -112,13 +112,7 @@ class PostgresqlHstoreTest < ActiveRecord::TestCase
     end
 
     def test_type_cast_hstore
-      assert @column
-
-      data = "\"1\"=>\"2\""
-      hash = @column.class.string_to_hstore data
-      assert_equal({'1' => '2'}, hash)
-      assert_equal({'1' => '2'}, @column.type_cast_from_database(data))
-
+      assert_equal({'1' => '2'}, @column.type_cast_from_database("\"1\"=>\"2\""))
       assert_equal({}, @column.type_cast_from_database(""))
       assert_equal({'key'=>nil}, @column.type_cast_from_database('key => NULL'))
       assert_equal({'c'=>'}','"a"'=>'b "a b'}, @column.type_cast_from_database(%q(c=>"}", "\"a\""=>"b \"a b")))
@@ -173,19 +167,19 @@ class PostgresqlHstoreTest < ActiveRecord::TestCase
     end
 
     def test_gen1
-      assert_equal(%q(" "=>""), @column.class.hstore_to_string({' '=>''}))
+      assert_equal(%q(" "=>""), @column.cast_type.type_cast_for_database({' '=>''}))
     end
 
     def test_gen2
-      assert_equal(%q(","=>""), @column.class.hstore_to_string({','=>''}))
+      assert_equal(%q(","=>""), @column.cast_type.type_cast_for_database({','=>''}))
     end
 
     def test_gen3
-      assert_equal(%q("="=>""), @column.class.hstore_to_string({'='=>''}))
+      assert_equal(%q("="=>""), @column.cast_type.type_cast_for_database({'='=>''}))
     end
 
     def test_gen4
-      assert_equal(%q(">"=>""), @column.class.hstore_to_string({'>'=>''}))
+      assert_equal(%q(">"=>""), @column.cast_type.type_cast_for_database({'>'=>''}))
     end
 
     def test_parse1