aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2019-03-03 13:08:50 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-03-06 08:12:41 +0900
commita67841eb61f808a965da0d61ea47e2d9810436b0 (patch)
tree0939b4bdf517e277c637d2c2f65ee78e3206f825 /activerecord/test
parent91ed21b304c468db8ce9fd830312c151432935d0 (diff)
downloadrails-a67841eb61f808a965da0d61ea47e2d9810436b0.tar.gz
rails-a67841eb61f808a965da0d61ea47e2d9810436b0.tar.bz2
rails-a67841eb61f808a965da0d61ea47e2d9810436b0.zip
Ensure `clear_cache!` clears the prepared statements cache
Since #23461, all adapters supports prepared statements, so that clears the prepared statements cache is no longer database specific. Actually, I struggled to identify the cause of random CI failure in #23461, that was missing `@statements.clear` in `clear_cache!`. This extracts `clear_cache!` to ensure the common concerns in the abstract adapter.
Diffstat (limited to 'activerecord/test')
-rw-r--r--activerecord/test/cases/bind_parameter_test.rb4
1 files changed, 4 insertions, 0 deletions
diff --git a/activerecord/test/cases/bind_parameter_test.rb b/activerecord/test/cases/bind_parameter_test.rb
index 03cc0dffbc..eb8b45431f 100644
--- a/activerecord/test/cases/bind_parameter_test.rb
+++ b/activerecord/test/cases/bind_parameter_test.rb
@@ -41,6 +41,10 @@ if ActiveRecord::Base.connection.prepared_statements
topics = Topic.where(id: 1)
assert_equal [1], topics.map(&:id)
assert_includes statement_cache, to_sql_key(topics.arel)
+
+ @connection.clear_cache!
+
+ assert_not_includes statement_cache, to_sql_key(topics.arel)
end
def test_statement_cache_with_query_cache