diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2017-12-03 15:45:40 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-12-03 15:45:40 +0900 |
| commit | 9b823c02b62a91216ef1ad0c9d4fca095377afb6 (patch) | |
| tree | 9271d31ea0792c852be829f665bedbbe14a6a17b /activerecord/test | |
| parent | 70fa9e9ab7fd89589664ecd7ee367448ef45f9d8 (diff) | |
| download | rails-9b823c02b62a91216ef1ad0c9d4fca095377afb6.tar.gz rails-9b823c02b62a91216ef1ad0c9d4fca095377afb6.tar.bz2 rails-9b823c02b62a91216ef1ad0c9d4fca095377afb6.zip | |
SQLite3 valid integer value should be 8 bytes (64-bit signed integer) (#28379)
This is a regression since Rails 4.2.
SQLite3 integer is stored in 1, 2, 3, 4, 6, or 8 bytes depending on the
magnitude of the value. Assuming default valid value as 4 bytes caused
that actual valid value in INTEGER storage class cannot be stored and
existing value cannot be found.
https://www.sqlite.org/datatype3.html
We should allow valid value in INTEGER storage class in SQLite3 to fix
the regression.
Fixes #22594.
Diffstat (limited to 'activerecord/test')
| -rw-r--r-- | activerecord/test/cases/base_test.rb | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/activerecord/test/cases/base_test.rb b/activerecord/test/cases/base_test.rb index d79afa2ee9..3497f6aae4 100644 --- a/activerecord/test/cases/base_test.rb +++ b/activerecord/test/cases/base_test.rb @@ -891,11 +891,9 @@ class BasicsTest < ActiveRecord::TestCase assert_equal 2147483648, company.rating end - unless current_adapter?(:SQLite3Adapter) - def test_bignum_pk - company = Company.create!(id: 2147483648, name: "foo") - assert_equal company, Company.find(company.id) - end + def test_bignum_pk + company = Company.create!(id: 2147483648, name: "foo") + assert_equal company, Company.find(company.id) end # TODO: extend defaults tests to other databases! |