diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2012-08-02 14:01:44 -0300 |
---|---|---|
committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2012-08-02 14:11:51 -0300 |
commit | 99f622de230e582c372e20f4b72792c0fce0fd4a (patch) | |
tree | 11e9b53483059998d333f9ed5534022c7a21bcdc /activerecord/test | |
parent | 59c4b22c4528e9f97d3eb394f603dc50c3cf41a9 (diff) | |
download | rails-99f622de230e582c372e20f4b72792c0fce0fd4a.tar.gz rails-99f622de230e582c372e20f4b72792c0fce0fd4a.tar.bz2 rails-99f622de230e582c372e20f4b72792c0fce0fd4a.zip |
Do not consider the numeric attribute as changed if the old value is
zero and the new value is not a string.
Before this commit this was the behavior
r = Review.find_by_issue(0)
r.issue
=> 0
r.changes
=> {}
r.issue = 0
=> 0
r.changed?
=> true
r.changes
=> {"issue"=>[0,0]}
Fixes #7237
Diffstat (limited to 'activerecord/test')
-rw-r--r-- | activerecord/test/cases/dirty_test.rb | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/activerecord/test/cases/dirty_test.rb b/activerecord/test/cases/dirty_test.rb index 60497ac5d8..d939e13d9a 100644 --- a/activerecord/test/cases/dirty_test.rb +++ b/activerecord/test/cases/dirty_test.rb @@ -201,7 +201,7 @@ class DirtyTest < ActiveRecord::TestCase end end - def test_nullable_integer_zero_to_string_zero_not_marked_as_changed + def test_integer_zero_to_string_zero_not_marked_as_changed pirate = Pirate.new pirate.parrot_id = 0 pirate.catchphrase = 'arrr' @@ -213,6 +213,19 @@ class DirtyTest < ActiveRecord::TestCase assert !pirate.changed? end + def test_integer_zero_to_integer_zero_not_marked_as_changed + pirate = Pirate.new + pirate.parrot_id = 0 + pirate.catchphrase = 'arrr' + assert pirate.save! + + assert !pirate.changed? + + pirate.parrot_id = 0 + assert !pirate.changed? + end + + def test_zero_to_blank_marked_as_changed pirate = Pirate.new pirate.catchphrase = "Yarrrr, me hearties" |