aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2014-12-26 17:01:05 -0700
committerSean Griffin <sean@thoughtbot.com>2014-12-26 17:01:05 -0700
commit8ce6fd559445188b1cbccafd50455ee217d2c752 (patch)
treeb4b613cb7939697072b71c6c45bb634a6c62c2b1 /activerecord/test
parentb4e6e47471ef951fe134a74cf71544c10a8638f5 (diff)
downloadrails-8ce6fd559445188b1cbccafd50455ee217d2c752.tar.gz
rails-8ce6fd559445188b1cbccafd50455ee217d2c752.tar.bz2
rails-8ce6fd559445188b1cbccafd50455ee217d2c752.zip
Inform Arel that we don't need to cast a value in tests
Part of the larger refactoring to remove type casting from Arel. We can inform it that we already have the right type by wrapping the value in an `Arel::Nodes::Quoted`. This commit can be reverted when we have removed type casting from Arel in Rail 5.1
Diffstat (limited to 'activerecord/test')
-rw-r--r--activerecord/test/cases/scoping/default_scoping_test.rb6
1 files changed, 4 insertions, 2 deletions
diff --git a/activerecord/test/cases/scoping/default_scoping_test.rb b/activerecord/test/cases/scoping/default_scoping_test.rb
index 0738df1b54..d56f998622 100644
--- a/activerecord/test/cases/scoping/default_scoping_test.rb
+++ b/activerecord/test/cases/scoping/default_scoping_test.rb
@@ -145,11 +145,13 @@ class DefaultScopingTest < ActiveRecord::TestCase
assert_equal expected_5, received_5
expected_6 = Developer.order('salary DESC').collect(&:name)
- received_6 = DeveloperOrderedBySalary.where(Developer.arel_table['name'].eq('David')).unscope(where: :name).collect(&:name)
+ # FIXME: Remove the Arel::Nodes::Quoted in Rails 5.1
+ received_6 = DeveloperOrderedBySalary.where(Developer.arel_table['name'].eq(Arel::Nodes::Quoted.new('David'))).unscope(where: :name).collect(&:name)
assert_equal expected_6, received_6
expected_7 = Developer.order('salary DESC').collect(&:name)
- received_7 = DeveloperOrderedBySalary.where(Developer.arel_table[:name].eq('David')).unscope(where: :name).collect(&:name)
+ # FIXME: Remove the Arel::Nodes::Quoted in Rails 5.1
+ received_7 = DeveloperOrderedBySalary.where(Developer.arel_table[:name].eq(Arel::Nodes::Quoted.new('David'))).unscope(where: :name).collect(&:name)
assert_equal expected_7, received_7
end