diff options
author | John Hawthorn <john@hawthorn.email> | 2019-07-29 11:06:27 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-29 11:06:27 -0700 |
commit | 8b0b591296448dd4dff5b85dbbbaf35f01f31e69 (patch) | |
tree | 80792c0c18613857ce980df41f01ff1771959a00 /activerecord/test | |
parent | e0b19a3622e9d6d328dde174165ac03719f565c4 (diff) | |
parent | 69700c9ee760c5880fc80af70a89b42bb791cf98 (diff) | |
download | rails-8b0b591296448dd4dff5b85dbbbaf35f01f31e69.tar.gz rails-8b0b591296448dd4dff5b85dbbbaf35f01f31e69.tar.bz2 rails-8b0b591296448dd4dff5b85dbbbaf35f01f31e69.zip |
Merge pull request #36782 from jhawthorn/move_database_exists_to_adapter
Move DatabaseAlreadyExists detection to DB adapter
Diffstat (limited to 'activerecord/test')
-rw-r--r-- | activerecord/test/cases/tasks/mysql_rake_test.rb | 6 | ||||
-rw-r--r-- | activerecord/test/cases/tasks/postgresql_rake_test.rb | 2 |
2 files changed, 3 insertions, 5 deletions
diff --git a/activerecord/test/cases/tasks/mysql_rake_test.rb b/activerecord/test/cases/tasks/mysql_rake_test.rb index ac3c5bc26e..4b039395e8 100644 --- a/activerecord/test/cases/tasks/mysql_rake_test.rb +++ b/activerecord/test/cases/tasks/mysql_rake_test.rb @@ -93,11 +93,9 @@ if current_adapter?(:Mysql2Adapter) with_stubbed_connection_establish_connection do ActiveRecord::Base.connection.stub( :create_database, - proc { raise ActiveRecord::StatementInvalid } + proc { raise ActiveRecord::DatabaseAlreadyExists } ) do - ActiveRecord::Base.connection.stub(:error_number, 1007) do - ActiveRecord::Tasks::DatabaseTasks.create @configuration - end + ActiveRecord::Tasks::DatabaseTasks.create @configuration assert_equal "Database 'my-app-db' already exists\n", $stderr.string end diff --git a/activerecord/test/cases/tasks/postgresql_rake_test.rb b/activerecord/test/cases/tasks/postgresql_rake_test.rb index f9df650687..d74ba0580d 100644 --- a/activerecord/test/cases/tasks/postgresql_rake_test.rb +++ b/activerecord/test/cases/tasks/postgresql_rake_test.rb @@ -129,7 +129,7 @@ if current_adapter?(:PostgreSQLAdapter) with_stubbed_connection_establish_connection do ActiveRecord::Base.connection.stub( :create_database, - proc { raise ActiveRecord::Tasks::DatabaseAlreadyExists } + proc { raise ActiveRecord::DatabaseAlreadyExists } ) do ActiveRecord::Tasks::DatabaseTasks.create @configuration |