diff options
author | Sean Griffin <sean@thoughtbot.com> | 2015-02-17 11:12:52 -0700 |
---|---|---|
committer | Sean Griffin <sean@thoughtbot.com> | 2015-02-17 11:12:52 -0700 |
commit | 89ba5bb45622394a33a196398671a0ff1737cd3e (patch) | |
tree | fa80456f1684fe024a50d4a8c89372e46efce252 /activerecord/test | |
parent | df3fc94ae32a95f5f90eb489650bccbe5f57b5c5 (diff) | |
download | rails-89ba5bb45622394a33a196398671a0ff1737cd3e.tar.gz rails-89ba5bb45622394a33a196398671a0ff1737cd3e.tar.bz2 rails-89ba5bb45622394a33a196398671a0ff1737cd3e.zip |
Revert "Allow `:precision` option for time type columns"
This reverts commit 1502caefd30b137fd1a0865be34c5bbf85ba64c1.
The test suite for the mysql adapter broke when this commit was used
with MySQL 5.6.
Conflicts:
activerecord/CHANGELOG.md
Diffstat (limited to 'activerecord/test')
-rw-r--r-- | activerecord/test/cases/time_precision_test.rb | 65 |
1 files changed, 0 insertions, 65 deletions
diff --git a/activerecord/test/cases/time_precision_test.rb b/activerecord/test/cases/time_precision_test.rb deleted file mode 100644 index 23422fd50a..0000000000 --- a/activerecord/test/cases/time_precision_test.rb +++ /dev/null @@ -1,65 +0,0 @@ -require 'cases/helper' - -if ActiveRecord::Base.connection.supports_datetime_with_precision? -class TimePrecisionTest < ActiveRecord::TestCase - setup do - @connection = ActiveRecord::Base.connection - end - - teardown do - @connection.drop_table :foos, if_exists: true - end - - def test_time_data_type_with_precision - @connection.create_table(:foos, force: true) - @connection.add_column :foos, :start, :time, precision: 3 - @connection.add_column :foos, :finish, :time, precision: 6 - assert_equal 3, activerecord_column_option('foos', 'start', 'precision') - assert_equal 6, activerecord_column_option('foos', 'finish', 'precision') - end - - def test_passing_precision_to_time_does_not_set_limit - @connection.create_table(:foos, force: true) do |t| - t.time :start, precision: 3 - t.time :finish, precision: 6 - end - assert_nil activerecord_column_option('foos', 'start', 'limit') - assert_nil activerecord_column_option('foos', 'finish', 'limit') - end - - def test_invalid_time_precision_raises_error - assert_raises ActiveRecord::ActiveRecordError do - @connection.create_table(:foos, force: true) do |t| - t.time :start, precision: 7 - t.time :finish, precision: 7 - end - end - end - - def test_database_agrees_with_activerecord_about_precision - @connection.create_table(:foos, force: true) do |t| - t.time :start, precision: 2 - t.time :finish, precision: 4 - end - assert_equal 2, database_datetime_precision('foos', 'start') - assert_equal 4, database_datetime_precision('foos', 'finish') - end - - private - - def database_datetime_precision(table_name, column_name) - results = @connection.exec_query("SELECT column_name, datetime_precision FROM information_schema.columns WHERE table_name = '#{table_name}'") - result = results.find do |result_hash| - result_hash["column_name"] == column_name - end - result && result["datetime_precision"].to_i - end - - def activerecord_column_option(tablename, column_name, option) - result = @connection.columns(tablename).find do |column| - column.name == column_name - end - result && result.send(option) - end -end -end |