aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2016-10-28 13:46:06 +0200
committerGitHub <noreply@github.com>2016-10-28 13:46:06 +0200
commit86bf5adaa810ef9d988cc64dbe1b466f0f74e817 (patch)
treedd529bfefb5be514dde084ca59c5f6d95e9d24b4 /activerecord/test
parent3f2046f00ab0046f9252a5a7b52f617028bc4e0c (diff)
parent444cf0d6424dcfaef009b9046b23c281791f0e9b (diff)
downloadrails-86bf5adaa810ef9d988cc64dbe1b466f0f74e817.tar.gz
rails-86bf5adaa810ef9d988cc64dbe1b466f0f74e817.tar.bz2
rails-86bf5adaa810ef9d988cc64dbe1b466f0f74e817.zip
Merge pull request #26688 from kamipo/remove_respond_to_indexes
Remove unnecessary `respond_to?(:indexes)` checking
Diffstat (limited to 'activerecord/test')
-rw-r--r--activerecord/test/cases/adapter_test.rb23
1 files changed, 9 insertions, 14 deletions
diff --git a/activerecord/test/cases/adapter_test.rb b/activerecord/test/cases/adapter_test.rb
index cfbc8ab942..8bcecf2ed3 100644
--- a/activerecord/test/cases/adapter_test.rb
+++ b/activerecord/test/cases/adapter_test.rb
@@ -72,20 +72,15 @@ module ActiveRecord
def test_indexes
idx_name = "accounts_idx"
- if @connection.respond_to?(:indexes)
- indexes = @connection.indexes("accounts")
- assert indexes.empty?
-
- @connection.add_index :accounts, :firm_id, name: idx_name
- indexes = @connection.indexes("accounts")
- assert_equal "accounts", indexes.first.table
- assert_equal idx_name, indexes.first.name
- assert !indexes.first.unique
- assert_equal ["firm_id"], indexes.first.columns
- else
- warn "#{@connection.class} does not respond to #indexes"
- end
-
+ indexes = @connection.indexes("accounts")
+ assert indexes.empty?
+
+ @connection.add_index :accounts, :firm_id, name: idx_name
+ indexes = @connection.indexes("accounts")
+ assert_equal "accounts", indexes.first.table
+ assert_equal idx_name, indexes.first.name
+ assert !indexes.first.unique
+ assert_equal ["firm_id"], indexes.first.columns
ensure
@connection.remove_index(:accounts, name: idx_name) rescue nil
end