Duplicate the hash provided to AR::Base#to_xml to prevent unexpected side effects [Koz]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

1 files changed, 15 insertions, 0 deletions

diff --git a/activerecord/test/xml_serialization_test.rb b/activerecord/test/xml_serialization_test.rb
index 2fd9006821..73ff354c48 100644
--- a/activerecord/test/xml_serialization_test.rb
+++ b/activerecord/test/xml_serialization_test.rb
@@ -1,4 +1,6 @@
 require 'abstract_unit'
+require 'fixtures/post'
+require 'fixtures/author'
 
 class Contact < ActiveRecord::Base
   # mock out self.columns so no pesky db is needed for these tests
@@ -107,4 +109,17 @@ class NilXmlSerializationTest < Test::Unit::TestCase
   def test_should_serialize_boolean
     assert_match %r{<awesome type=\"boolean\"></awesome>}, @xml
   end
+end
+
+class DatabaseConnectedXmlSerializationTest < Test::Unit::TestCase
+  fixtures :authors, :posts
+  # to_xml used to mess with the hash the user provided which
+  # caused the builder to be reused
+  def test_passing_hash_shouldnt_reuse_builder
+    options = {:include=>:posts}
+    david = authors(:david)
+    first_xml_size = david.to_xml(options).size
+    second_xml_size = david.to_xml(options).size
+    assert_equal first_xml_size, second_xml_size
+  end
 end
\ No newline at end of file