diff options
author | Jeremy Daer <jeremydaer@gmail.com> | 2016-03-03 16:05:40 -0700 |
---|---|---|
committer | Jeremy Daer <jeremydaer@gmail.com> | 2016-03-03 16:43:28 -0700 |
commit | af260f649bb5912f37842221926402761e4ca2e9 (patch) | |
tree | 3c146f8261c023c2da427fb7c76c6b72e83e2920 /activerecord/test/support/schema_dumping_helper.rb | |
parent | daeaac702795f2ab6bb882abef1a349b1b799b22 (diff) | |
download | rails-af260f649bb5912f37842221926402761e4ca2e9.tar.gz rails-af260f649bb5912f37842221926402761e4ca2e9.tar.bz2 rails-af260f649bb5912f37842221926402761e4ca2e9.zip |
Refinement of our "are you missing a template or did you omit it on purpose?" heuristics
Narrows the "are you in a browser, viewing the page?" check to exclude
non-GET requests. Allows content-less APIs to use implicit responses
without having to set a fake request format.
This will need further attention. If you forget to redirect from a POST
to a GET, you'll get a 204 No Content response that browsers will
typically treat as… do nothing. It'll seem like the form just didn't
work and knowing where to start debugging is non-obvious.
On the flip side, redirecting from POST and others is the default, done
everywhere, so it's less likely to be removed or otherwise missed.
Alternatives are to do more explicit browser sniffing.
Ref #23827.
Diffstat (limited to 'activerecord/test/support/schema_dumping_helper.rb')
0 files changed, 0 insertions, 0 deletions