diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2018-10-24 10:31:41 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2018-10-24 11:26:49 +0900 |
| commit | ce40073c9c321575e6b4f46dd5ac9b796a2637be (patch) | |
| tree | 0e57b4f8c46ff591122cec58d248fe39125e3bbf /activerecord/test/schema | |
| parent | dc6761592009e9146552fc9d6299bf58a34e187a (diff) | |
| download | rails-ce40073c9c321575e6b4f46dd5ac9b796a2637be.tar.gz rails-ce40073c9c321575e6b4f46dd5ac9b796a2637be.tar.bz2 rails-ce40073c9c321575e6b4f46dd5ac9b796a2637be.zip | |
Lazy checking whether or not values in IN clause are boundable
Since #33844, eager loading/preloading with too many and/or too large
ids won't be broken by pre-checking whether the value is constructable
or not.
But the pre-checking caused the type to be evaluated at relation build
time instead of at the query execution time, that is breaking an
expectation for some apps.
I've made the pre-cheking lazy as much as possible, that is no longer
happend at relation build time.
Diffstat (limited to 'activerecord/test/schema')
| -rw-r--r-- | activerecord/test/schema/schema.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/activerecord/test/schema/schema.rb b/activerecord/test/schema/schema.rb index 2aaf393009..4ef463fdad 100644 --- a/activerecord/test/schema/schema.rb +++ b/activerecord/test/schema/schema.rb @@ -93,7 +93,7 @@ ActiveRecord::Schema.define do t.integer :pirate_id end - create_table :books, force: true do |t| + create_table :books, id: :integer, force: true do |t| t.references :author t.string :format t.column :name, :string @@ -158,8 +158,8 @@ ActiveRecord::Schema.define do end create_table :citations, force: true do |t| - t.column :book1_id, :integer - t.column :book2_id, :integer + t.references :book1 + t.references :book2 t.references :citation end |