diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2017-07-21 12:26:09 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2019-01-18 16:01:14 +0900 |
| commit | c196ca72a0dfbea5f1730f830ea20a9e02a3c737 (patch) | |
| tree | 2017197758672519af2a2ef44eb674af35491a99 /activerecord/test/models | |
| parent | 31ffbf8d5056137717da3f11d28c4fbd7fbc8f07 (diff) | |
| download | rails-c196ca72a0dfbea5f1730f830ea20a9e02a3c737.tar.gz rails-c196ca72a0dfbea5f1730f830ea20a9e02a3c737.tar.bz2 rails-c196ca72a0dfbea5f1730f830ea20a9e02a3c737.zip | |
Ensure `StatementCache#execute` never raises `RangeError`
Since 31ffbf8d, finder methods no longer raise `RangeError`. So
`StatementCache#execute` is the only place to raise the exception for
finder queries.
`StatementCache` is used for simple equality queries in the codebase.
This means that if `StatementCache#execute` raises `RangeError`, the
result could always be regarded as empty.
So `StatementCache#execute` just return nil in that range error case,
and treat that as empty in the caller side, then we can avoid catching
the exception in much places.
Diffstat (limited to 'activerecord/test/models')
| -rw-r--r-- | activerecord/test/models/reference.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/activerecord/test/models/reference.rb b/activerecord/test/models/reference.rb index 2a7a1e3b77..82185040d6 100644 --- a/activerecord/test/models/reference.rb +++ b/activerecord/test/models/reference.rb @@ -4,6 +4,7 @@ class Reference < ActiveRecord::Base belongs_to :person belongs_to :job + has_many :ideal_jobs, class_name: "Job", foreign_key: :ideal_reference_id has_many :agents_posts_authors, through: :person class << self; attr_accessor :make_comments; end |