aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/models/recipe.rb
diff options
context:
space:
mode:
authoreileencodes <eileencodes@gmail.com>2015-03-15 10:33:29 -0400
committereileencodes <eileencodes@gmail.com>2015-03-15 10:39:42 -0400
commit51660f0191a7c71ce298c71e7366ebab55be729c (patch)
tree326e7e3c22269759b1bb0c194e1384f2b396e90b /activerecord/test/models/recipe.rb
parentb6c038b600487b1adcf8f5e69ba70a992b07e195 (diff)
downloadrails-51660f0191a7c71ce298c71e7366ebab55be729c.tar.gz
rails-51660f0191a7c71ce298c71e7366ebab55be729c.tar.bz2
rails-51660f0191a7c71ce298c71e7366ebab55be729c.zip
Fix leaky chain on polymorphic association
If there was a polymorphic hm:t association with a scope AND second non-scoped hm:t association on a model the polymorphic scope would leak through into the call for the non-polymorhic hm:t association. This would only break if `hotel.drink_designers` was called before `hotel.recipes`. If `hotel.recipes` was called first there would be no problem with the SQL. Before (employable_type should not be here): ``` SELECT COUNT(*) FROM "drink_designers" INNER JOIN "chefs" ON "drink_designers"."id" = "chefs"."employable_id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? AND "chefs"."employable_type" = ? [["hotel_id", 1], ["employable_type", "DrinkDesigner"]] ``` After: ``` SELECT COUNT(*) FROM "recipes" INNER JOIN "chefs" ON "recipes"."chef_id" = "chefs"."id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? [["hotel_id", 1]] ``` From the SQL you can see that `employable_type` was leaking through when calling recipes. The solution is to dup the chain of the polymorphic association so it doesn't get cached. Additionally, this follows `scope_chain` which dup's the `source_reflection`'s `scope_chain`. This required another model/table/relationship because the leak only happens on a hm:t polymorphic that's called before another hm:t on the same model. I am specifically testing the SQL here instead of the number of records becasue the test could pass if there was 1 drink designer recipe for the drink designer chef even though the `employable_type` was leaking through. This needs to specifically check that `employable_type` is not in the SQL statement.
Diffstat (limited to 'activerecord/test/models/recipe.rb')
-rw-r--r--activerecord/test/models/recipe.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/activerecord/test/models/recipe.rb b/activerecord/test/models/recipe.rb
new file mode 100644
index 0000000000..c387230603
--- /dev/null
+++ b/activerecord/test/models/recipe.rb
@@ -0,0 +1,3 @@
+class Recipe < ActiveRecord::Base
+ belongs_to :chef
+end