aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/fixtures
diff options
context:
space:
mode:
authorSeb Jacobs <me@sebjacobs.com>2015-01-15 23:03:23 +0000
committerSeb Jacobs <me@sebjacobs.com>2015-01-16 11:41:43 +0000
commitd5bf649a535948e70692e521ce3070595334e71b (patch)
treed1f56e9ff058eceba35785bbeb1d88e54e15e910 /activerecord/test/fixtures
parent090c5211ced7b728df6176d5c9fc7437c107beaf (diff)
downloadrails-d5bf649a535948e70692e521ce3070595334e71b.tar.gz
rails-d5bf649a535948e70692e521ce3070595334e71b.tar.bz2
rails-d5bf649a535948e70692e521ce3070595334e71b.zip
Add support for bidirectional destroy dependencies
Prior to this commit if you defined a bidirectional relationship between two models with destroy dependencies on both sides, a call to `destroy` would result in an infinite callback loop. Take the following relationship. class Content < ActiveRecord::Base has_one :content_position, dependent: :destroy end class ContentPosition < ActiveRecord::Base belongs_to :content, dependent: :destroy end Calling `Content#destroy` or `ContentPosition#destroy` would result in an infinite callback loop. This commit changes the behaviour of `ActiveRecord::Callbacks#destroy` so that it guards against subsequent callbacks. Thanks to @zetter for demonstrating the issue with failing tests[1]. [1] rails#13609
Diffstat (limited to 'activerecord/test/fixtures')
-rw-r--r--activerecord/test/fixtures/content.yml3
-rw-r--r--activerecord/test/fixtures/content_positions.yml3
2 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/test/fixtures/content.yml b/activerecord/test/fixtures/content.yml
new file mode 100644
index 0000000000..0d12ee03dc
--- /dev/null
+++ b/activerecord/test/fixtures/content.yml
@@ -0,0 +1,3 @@
+content:
+ id: 1
+ title: How to use Rails
diff --git a/activerecord/test/fixtures/content_positions.yml b/activerecord/test/fixtures/content_positions.yml
new file mode 100644
index 0000000000..9e85773f8e
--- /dev/null
+++ b/activerecord/test/fixtures/content_positions.yml
@@ -0,0 +1,3 @@
+content_positions:
+ id: 1
+ content_id: 1