aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
diff options
context:
space:
mode:
authoryui-knk <spiketeika@gmail.com>2016-03-24 20:03:43 +0900
committeryui-knk <spiketeika@gmail.com>2016-03-24 20:45:23 +0900
commitcf570d7d0153283d2175b7330270d94291884864 (patch)
tree2ff43614ead7e934d4bb9e96b9c1da69cbf8012d /activerecord/test/cases
parent878c2bbaaf21f88543e75d4a986652d128ea8448 (diff)
downloadrails-cf570d7d0153283d2175b7330270d94291884864.tar.gz
rails-cf570d7d0153283d2175b7330270d94291884864.tar.bz2
rails-cf570d7d0153283d2175b7330270d94291884864.zip
Change for `ActiveRecord::Migration.[]` to raise `ArgumentError` instead of `RuntimeError`
The error is raised because user passed invalid version number to a public api of `ActiveRecord`, so `ArgumentError` is more suitable. And add a test case checking if an error is raised when unknown migration version is passed, because these test cases are not implemented.
Diffstat (limited to 'activerecord/test/cases')
-rw-r--r--activerecord/test/cases/migration_test.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/activerecord/test/cases/migration_test.rb b/activerecord/test/cases/migration_test.rb
index 6a6250eec3..5a6d2ce80c 100644
--- a/activerecord/test/cases/migration_test.rb
+++ b/activerecord/test/cases/migration_test.rb
@@ -1107,4 +1107,7 @@ class CopyMigrationsTest < ActiveRecord::TestCase
ActiveRecord::Base.logger = old
end
+ def test_unknown_migration_version_should_raise_an_argument_error
+ assert_raise(ArgumentError) { ActiveRecord::Migration[1.0] }
+ end
end