aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
diff options
context:
space:
mode:
authorMike Busch <mbusch@heroku.com>2017-01-23 12:09:14 -0500
committerMike Busch <mbusch@heroku.com>2017-12-22 07:41:33 -0500
commitc53287b2370af2b011cdc4c583a50fbcd6fd88ed (patch)
treedbd665902c1f6ec070f057a8b063923e12b4a2d3 /activerecord/test/cases
parent0901755283645be1a59d625deb3471c40d664712 (diff)
downloadrails-c53287b2370af2b011cdc4c583a50fbcd6fd88ed.tar.gz
rails-c53287b2370af2b011cdc4c583a50fbcd6fd88ed.tar.bz2
rails-c53287b2370af2b011cdc4c583a50fbcd6fd88ed.zip
save attributes changed by callbacks after update_attribute
update_attribute previously stopped execution, before saving and before running callbacks, if the record's attributes hadn't changed. [The documentation](http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html#method-i-update_attribute) says that "Callbacks are invoked", which was not happening if the persisted attributes hadn't changed.
Diffstat (limited to 'activerecord/test/cases')
-rw-r--r--activerecord/test/cases/persistence_test.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/activerecord/test/cases/persistence_test.rb b/activerecord/test/cases/persistence_test.rb
index 07c4a17fb1..0fa8ea212f 100644
--- a/activerecord/test/cases/persistence_test.rb
+++ b/activerecord/test/cases/persistence_test.rb
@@ -633,6 +633,9 @@ class PersistenceTest < ActiveRecord::TestCase
Topic.find(1).update_attribute(:approved, false)
assert !Topic.find(1).approved?
+
+ Topic.find(1).update_attribute(:change_approved_before_save, true)
+ assert Topic.find(1).approved?
end
def test_update_attribute_for_readonly_attribute