aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2017-06-29 16:21:26 +0200
committerGitHub <noreply@github.com>2017-06-29 16:21:26 +0200
commita317af93a39edcd3adbdea21e7d5c377709968f4 (patch)
treeedb7f0595cb56f93adc833bc4dae69b7d586df9b /activerecord/test/cases
parent4448873c8755524ccadd639d1a08df53496c36d7 (diff)
parentd9fca84d218f0ed784c7bf6470df42d41838e507 (diff)
downloadrails-a317af93a39edcd3adbdea21e7d5c377709968f4.tar.gz
rails-a317af93a39edcd3adbdea21e7d5c377709968f4.tar.bz2
rails-a317af93a39edcd3adbdea21e7d5c377709968f4.zip
Merge pull request #29619 from kamipo/deprecate_delegating_to_arel_in_relation
Deprecate delegating to `arel` in `Relation`
Diffstat (limited to 'activerecord/test/cases')
-rw-r--r--activerecord/test/cases/relation/delegation_test.rb15
1 files changed, 15 insertions, 0 deletions
diff --git a/activerecord/test/cases/relation/delegation_test.rb b/activerecord/test/cases/relation/delegation_test.rb
index cb6e4d76d3..3b15f051b2 100644
--- a/activerecord/test/cases/relation/delegation_test.rb
+++ b/activerecord/test/cases/relation/delegation_test.rb
@@ -21,8 +21,22 @@ module ActiveRecord
end
end
+ module DeprecatedArelDelegationTests
+ AREL_METHODS = [
+ :with, :orders, :froms, :project, :projections, :taken, :constraints, :exists, :locked, :where_sql,
+ :ast, :source, :join_sources, :to_dot, :bind_values, :create_insert, :create_true, :create_false
+ ]
+
+ def test_deprecate_arel_delegation
+ AREL_METHODS.each do |method|
+ assert_deprecated { target.public_send(method) }
+ end
+ end
+ end
+
class DelegationAssociationTest < ActiveRecord::TestCase
include DelegationWhitelistTests
+ include DeprecatedArelDelegationTests
fixtures :posts
@@ -33,6 +47,7 @@ module ActiveRecord
class DelegationRelationTest < ActiveRecord::TestCase
include DelegationWhitelistTests
+ include DeprecatedArelDelegationTests
fixtures :comments