diff options
| author | Sean Griffin <sean@seantheprogrammer.com> | 2016-01-27 13:26:20 -0500 |
|---|---|---|
| committer | Sean Griffin <sean@seantheprogrammer.com> | 2016-01-27 13:26:20 -0500 |
| commit | 77383fc1e473819971d1e3ca614d7b361fa5cc33 (patch) | |
| tree | 6e81f97075d4aef0083b9c2f8249ba24cdf78510 /activerecord/test/cases | |
| parent | 9864bcee8cfdb9e798473e01936b4499e268a64d (diff) | |
| download | rails-77383fc1e473819971d1e3ca614d7b361fa5cc33.tar.gz rails-77383fc1e473819971d1e3ca614d7b361fa5cc33.tar.bz2 rails-77383fc1e473819971d1e3ca614d7b361fa5cc33.zip | |
Do not use default attributes for STI when instantiating a subclass
The commit which originally added this behavior did not consider that
doing `Subclass.new` does not actually populate the `type` field in the
attributes (though perhaps it should). We simply need to not use the
defaults for STI related things unless we are instantiating the base
class.
Fixes #23285.
Diffstat (limited to 'activerecord/test/cases')
| -rw-r--r-- | activerecord/test/cases/inheritance_test.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/activerecord/test/cases/inheritance_test.rb b/activerecord/test/cases/inheritance_test.rb index c870247a4a..7da6842047 100644 --- a/activerecord/test/cases/inheritance_test.rb +++ b/activerecord/test/cases/inheritance_test.rb @@ -493,6 +493,10 @@ class InheritanceComputeTypeTest < ActiveRecord::TestCase assert_equal 'Firm', firm.type assert_instance_of Firm, firm + client = Client.new + assert_equal 'Client', client.type + assert_instance_of Client, client + firm = Company.new(type: 'Client') # overwrite the default type assert_equal 'Client', firm.type assert_instance_of Client, firm |